[#12663] Instructor's Student Records Page: Tooltips for comments #12676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domlimm
approved these changes
Dec 28, 2023
wkurniawan07
added
c.Bug
cedricongjh
pushed a commit
to cedricongjh/teammates
that referenced
this pull request
Feb 20, 2024
…ments (TEAMMATES#12676) * Fix comment tooltip causing the text to go into next line * Update snapshot test --------- Co-authored-by: YX Z <yxz@YXs-MacBook-Air-2.local> Co-authored-by: Wei Qing <48304907+weiquu@users.noreply.github.com> Co-authored-by: Dominic Lim <46486515+domlimm@users.noreply.github.com> Co-authored-by: Jason Qiu <jason_qiu@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12663
Outline of Solution
The tooltip for comment/edit time causes the rest of the text to go into the next line is because comment/edit time's parent element is a
<span>. The tooltip window element created when hovering over the comment/edit time will be a a child element of this<span>. Changing it to a block element<ng-container>fixes the issue.Alternative:
An alternative is to set
container="body"so that the tooltip will be attached as a last child of the element (doc) this makes sure that the tooltip window is outside of the<span>element.Screenshots:
