[#10955] Wrap up Objectify V6 migration #11058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkurniawan07
force-pushed
the
teammatesv8
branch
from
9f51def
to
b5ce17b
Compare
* update objectify dependency to v6 and fix initial build issues * reset localhost port to default * updated cloud datastore cursor api for v6 * add missing Objectify.init() in base test case * add project id information into Objectify.init() * fixed wrong order from auto import * include localDatastoreHelper test config * fixed deleteEntity key id compatibility to v6 * updated e2e test setup for local datastore helper * remove local datastore service test config * remove not equal DB operation * added local datastore helper for e2e testing * Generate legacy key format consistent with the old appengine SDK * moved localDatastoreHelper setup from OfyHelper to base test case * moved datastore port config to build.template.properties * improved on documentation * refactored emulator port config Co-authored-by: jianhandev <jianhanli.dev@gmail.com>
* Replace usage of Text type from appengine datastore api with StringValue * Use unindexed String as alternative over StringValue previously used to replace Text * Simplify getters and setters * Remove redundant architecture test method after deprecating use of datastore Text type
#11025) * Remove usage of DatastoreTimeoutException from old api * Get WebApiServlet to throw specific datastore error messages * Replace hard-coded values with enum values of google.rpc.Code
wkurniawan07
force-pushed
the
objectify-v6-migration
branch
from
95a2b4e
to
f768ad3
Compare
|
@Derek-Hardy @jianhandev please help to do one last sanity check |
jianhandev
reviewed
Mar 23, 2021
Derek-Hardy
approved these changes
Mar 23, 2021
Derek-Hardy
added
s.ToMerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10955
This PR will symbolically move all the commits from the Objectify v6 migration PRs to the longer-living
teammatesv8branch.Merging shall be using the rebase-and-merge option.