[#11120] [#11121] Implement HTTP request interceptor and structured logging #11160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrtheonlyone
requested changes
May 30, 2021
There was a problem hiding this comment.
Thanks for the work here @wkurniawan07 - looks good.
Wondering how I go about testing this locally? i.e Is there anything specifically I need to change to build and run the web server
My comments are below:
wkurniawan07
added
s.ToMerge
wkurniawan07
added a commit
that referenced
this pull request
Jun 2, 2021
…ogging (#11160) * Replace Config.getRequestId with tracing function with ThreadLocal * Replace DeadlineExceededException with self-maintained timer * Include automated request endpoints in origin check configuration * Incorporate structured logging to enable grouping of logs
wkurniawan07
added a commit
that referenced
this pull request
Jun 6, 2021
…ogging (#11160) * Replace Config.getRequestId with tracing function with ThreadLocal * Replace DeadlineExceededException with self-maintained timer * Include automated request endpoints in origin check configuration * Incorporate structured logging to enable grouping of logs
wkurniawan07
added
the
c.DevOps
wkurniawan07
added a commit
that referenced
this pull request
Jun 6, 2021
…ogging (#11160) * Replace Config.getRequestId with tracing function with ThreadLocal * Replace DeadlineExceededException with self-maintained timer * Include automated request endpoints in origin check configuration * Incorporate structured logging to enable grouping of logs
daongochieu2810
pushed a commit
to daongochieu2810/teammates
that referenced
this pull request
Jul 5, 2021
…r and structured logging (TEAMMATES#11160) * Replace Config.getRequestId with tracing function with ThreadLocal * Replace DeadlineExceededException with self-maintained timer * Include automated request endpoints in origin check configuration * Incorporate structured logging to enable grouping of logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11120
Fixes #11121
Fixing two issues together because both involves creating a filter to intercept incoming HTTP requests.
The last commit enables structured logging.