-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#11120] [#11121] Implement HTTP request interceptor and structured logging #11160
[#11120] [#11121] Implement HTTP request interceptor and structured logging #11160
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work here @wkurniawan07 - looks good.
Wondering how I go about testing this locally? i.e Is there anything specifically I need to change to build and run the web server
My comments are below:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ogging (#11160) * Replace Config.getRequestId with tracing function with ThreadLocal * Replace DeadlineExceededException with self-maintained timer * Include automated request endpoints in origin check configuration * Incorporate structured logging to enable grouping of logs
…ogging (#11160) * Replace Config.getRequestId with tracing function with ThreadLocal * Replace DeadlineExceededException with self-maintained timer * Include automated request endpoints in origin check configuration * Incorporate structured logging to enable grouping of logs
…ogging (#11160) * Replace Config.getRequestId with tracing function with ThreadLocal * Replace DeadlineExceededException with self-maintained timer * Include automated request endpoints in origin check configuration * Incorporate structured logging to enable grouping of logs
…r and structured logging (TEAMMATES#11160) * Replace Config.getRequestId with tracing function with ThreadLocal * Replace DeadlineExceededException with self-maintained timer * Include automated request endpoints in origin check configuration * Incorporate structured logging to enable grouping of logs
Fixes #11120
Fixes #11121
Fixing two issues together because both involves creating a filter to intercept incoming HTTP requests.
The last commit enables structured logging.