[#11254] Instructor Feedback Session Results: Session Duration formatting

[ericluoliu]

Fixes #11254

[halfwhole]

Hi @ericluoliu, it looks like the issue still persists even with these changes! For example:

With your suggested change along with the existing line of code below, the entire session duration text will consist of non-breaking spaces, but because it's too long, it still has to break somewhere (leading to the situation in the image above):

teammates/src/web/app/pages-instructor/instructor-session-result-page/instructor-session-result-page.component.html

Line 28 in 48b67ba

<p class="form-control-static">{{ formattedSessionOpeningTime }}&nbsp;&nbsp;&nbsp;<b>to</b>&nbsp;&nbsp;&nbsp;{{ formattedSessionClosingTime }}</p>

To resolve this, we could perhaps either: use all normal spaces everywhere, but make a line-break after the 'to'; or we could use normal spaces before and after the 'to', along with non-breaking spaces in the formatted opening/closing times. (I might favour the first approach actually!)

[ericluoliu]

Hi @halfwhole , sorry for the very delayed response. I made the suggested changes and reverted my old changes.

[halfwhole]

The session duration box now looks like this, as the whitespaces before the 'to' are collapsed into a single space, and the whitespaces after the <br> are ignored:

May I suggest changing the 3 whitespaces before the 'to' back to non-breaking spaces, and simply removing the 3 whitespaces after the linebreak? That should resolve the issue

[ericluoliu]

Done.

[halfwhole]

LGTM

[ericluoliu]

E2E Tests give me an error. I think it is because it expects just a tab rather than an entire line break in the spot we changed.

[halfwhole]

In that case, could you update the relevant code used in the E2E tests too? The relevant lines should be here:

teammates/src/e2e/java/teammates/e2e/pageobjects/InstructorFeedbackResultsPage.java

Lines 781 to 784 in 8a97db6

	private String getSessionDurationString(FeedbackSessionAttributes feedbackSession) {
	return getDateString(feedbackSession.getStartTime(), feedbackSession.getTimeZone()) + " to "
	+ getDateString(feedbackSession.getEndTime(), feedbackSession.getTimeZone());
	}

[nusoss-bot]

Guys, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

[rrtheonlyone]

LGTM