-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#11254] Instructor Feedback Session Results: Session Duration formatting #11272
[#11254] Instructor Feedback Session Results: Session Duration formatting #11272
Conversation
…eningTime and formattedSessionClosingTime
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ericluoliu, it looks like the issue still persists even with these changes! For example:
With your suggested change along with the existing line of code below, the entire session duration text will consist of non-breaking spaces, but because it's too long, it still has to break somewhere (leading to the situation in the image above):
Line 28 in 48b67ba
<p class="form-control-static">{{ formattedSessionOpeningTime }} <b>to</b> {{ formattedSessionClosingTime }}</p> |
To resolve this, we could perhaps either: use all normal spaces everywhere, but make a line-break after the 'to'; or we could use normal spaces before and after the 'to', along with non-breaking spaces in the formatted opening/closing times. (I might favour the first approach actually!)
…instruction-session-result-page-format
Hi @halfwhole , sorry for the very delayed response. I made the suggested changes and reverted my old changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The session duration box now looks like this, as the whitespaces before the 'to' are collapsed into a single space, and the whitespaces after the <br>
are ignored:
May I suggest changing the 3 whitespaces before the 'to' back to non-breaking spaces, and simply removing the 3 whitespaces after the linebreak? That should resolve the issue
…instruction-session-result-page-format
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case, could you update the relevant code used in the E2E tests too? The relevant lines should be here:
teammates/src/e2e/java/teammates/e2e/pageobjects/InstructorFeedbackResultsPage.java
Lines 781 to 784 in 8a97db6
private String getSessionDurationString(FeedbackSessionAttributes feedbackSession) { | |
return getDateString(feedbackSession.getStartTime(), feedbackSession.getTimeZone()) + " to " | |
+ getDateString(feedbackSession.getEndTime(), feedbackSession.getTimeZone()); | |
} |
Guys, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #11254