-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#11385] Docker Compose sometimes failing on Windows because of line-endings #11386
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing yet again!
I'm a bit unsure as to whether it is ok to normalize all *.sh
files (as opposed to just the ones copied to some Docker contexts), although thus far it looks ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While the addition is ok, I have just a teensy change request
I can't evaluate if this PR is functional on Windows haha... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I currently do not have means to confirm whether it works as intended, I would believe it does by purely looking at the change introduced. Thanks once again!
Fixes #11385
Not much to say about it....
Solr was crashing because of line-endings, and this should fix that.
Here's hoping the auto-checks work...