Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#11385] Docker Compose sometimes failing on Windows because of line-endings #11386

Merged
merged 4 commits into from
Aug 26, 2021
Merged

[#11385] Docker Compose sometimes failing on Windows because of line-endings #11386

merged 4 commits into from
Aug 26, 2021

Conversation

TomKemperNL
Copy link
Contributor

@TomKemperNL TomKemperNL commented Aug 22, 2021 •
edited
Loading

Fixes #11385

Not much to say about it....

Solr was crashing because of line-endings, and this should fix that.

Here's hoping the auto-checks work...

wkurniawan07
wkurniawan07 reviewed Aug 22, 2021
View reviewed changes
Copy link
Member

@wkurniawan07 wkurniawan07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing yet again!
I'm a bit unsure as to whether it is ok to normalize all *.sh files (as opposed to just the ones copied to some Docker contexts), although thus far it looks ok.

.gitattributes Outdated Show resolved Hide resolved
wkurniawan07
wkurniawan07 reviewed Aug 23, 2021
View reviewed changes
Copy link
Member

@wkurniawan07 wkurniawan07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the addition is ok, I have just a teensy change request

.gitattributes Outdated Show resolved Hide resolved
@madanalogy madanalogy added the s.Ongoing The PR is being worked on by the author(s) label Aug 24, 2021
@madanalogy madanalogy added s.ToReview The PR is waiting for review(s) and removed s.Ongoing The PR is being worked on by the author(s) labels Aug 26, 2021
@moziliar
Copy link
Contributor

I can't evaluate if this PR is functional on Windows haha...

wkurniawan07
wkurniawan07 approved these changes Aug 26, 2021
View reviewed changes
Copy link
Member

@wkurniawan07 wkurniawan07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I currently do not have means to confirm whether it works as intended, I would believe it does by purely looking at the change introduced. Thanks once again!

@wkurniawan07 wkurniawan07 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging c.Task Other non-user-facing works, e.g. refactoring, adding tests and removed s.ToReview The PR is waiting for review(s) labels Aug 26, 2021
@wkurniawan07 wkurniawan07 added this to the V8.2.0 milestone Aug 26, 2021
@wkurniawan07 wkurniawan07 merged commit 00f178a into TEAMMATES:master Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wkurniawan07 wkurniawan07 wkurniawan07 approved these changes

@moziliar moziliar Awaiting requested review from moziliar

Assignees

@wkurniawan07 wkurniawan07

Labels
c.Task Other non-user-facing works, e.g. refactoring, adding tests s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V8.2.0
Development

Successfully merging this pull request may close these issues.

Docker Compose sometimes failing on Windows because of line-endings
4 participants
@TomKemperNL @moziliar @wkurniawan07 @madanalogy