Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#11586] Remove trailing @gmail.com when checking for user ID equality #11923

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

wkurniawan07
Copy link
Member

Part of #11586

@wkurniawan07 wkurniawan07 added the s.ToReview The PR is waiting for review(s) label Aug 3, 2022
@wkurniawan07 wkurniawan07 added this to the V8.19.2 milestone Aug 3, 2022
@wkurniawan07 wkurniawan07 added the c.Bug Bug/defect report label Aug 3, 2022
@xyliew25
Copy link
Contributor

xyliew25 commented Aug 3, 2022

@wkurniawan07 I think isAllowedAccess = userInfo != null && googleId.equals(userInfo.id); in GetRegkeyValidityAction.java should be modified such that registered student/instructor can access the session submission/result page when clicked on the corresponding link.

Regarding profiles, I think getStudentProfileEntityFromDb() in ProfileDb.java should be modified such that StudentProfile of old googleId can be retrieved. As for profile pictures, since both PostStudentProfilePictureAction and DeleteStudentProfilePictureAction are w.r.t. to new googleId while GetStudentProfilePictureAction is w.r.t. to old googleId, I'm not sure yet (still trying out myself) but I think we need to change GetStudentProfilePictureAction such that it first retrieves profile picture of new googleId, if null, then retrieves the profile picture of old googleId, and change DeleteStudentProfilePictureAction such that it deletes profile pictures of both old and new googleId if any.

@wkurniawan07
Copy link
Member Author

@xyliew25 I missed the first one, so good catch. Regarding profiles, given how rare it is used in recent times, I don't think it is worth it to fix. I even dare to say that it will not see any new usage by the time we migrated the old google IDs.

@xyliew25
Copy link
Contributor

xyliew25 commented Aug 3, 2022

@wkurniawan07 noted on the profiles.

Copy link
Contributor

@xyliew25 xyliew25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wkurniawan07 wkurniawan07 merged commit 3155a78 into TEAMMATES:master Aug 3, 2022
@wkurniawan07 wkurniawan07 deleted the username-equals branch August 3, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c.Bug Bug/defect report s.ToReview The PR is waiting for review(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants