Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove trimming of gmail.com for user accounts #11586

Closed
wkurniawan07 opened this issue Feb 21, 2022 · 2 comments · Fixed by #11927
Closed

Remove trimming of gmail.com for user accounts #11586

wkurniawan07 opened this issue Feb 21, 2022 · 2 comments · Fixed by #11927
Assignees
@xyliew25
Labels
a-Design High-level design or architecture c.Task Other non-user-facing works, e.g. refactoring, adding tests
Projects
Authentication Plus

Comments

@wkurniawan07
Copy link
Member

teammates/src/main/java/teammates/common/util/SanitizationHelper.java

Lines 53 to 55 in f70ae53

if (sanitized.toLowerCase().endsWith("@gmail.com")) {
sanitized = sanitized.split("@")[0];
}

teammates/src/main/java/teammates/ui/servlets/DevServerLoginServlet.java

Line 63 in f70ae53

UserInfoCookie uic = new UserInfoCookie(email.replaceFirst("@gmail\\.com$", ""));

teammates/src/main/java/teammates/ui/servlets/OAuth2CallbackServlet.java

Line 85 in f70ae53

googleId = email.replaceFirst("@gmail\\.com$", "");

Removing the trailing @gmail.com is a practice forced to us by the old and deprecated GAE Users API. We do not have any reason to do that anymore, so this practice needs to cease.

Need to also migrate entities who are scarred by this practice: accounts, students, instructors. Namely, if the googleId does not contain any @, it should be appended with @gmail.com.
@wkurniawan07 wkurniawan07 added help wanted Moderate difficulty, small localized change; suitable for novice contributors c.Task Other non-user-facing works, e.g. refactoring, adding tests a-Design High-level design or architecture labels Feb 21, 2022
@daongochieu2810
Copy link
Contributor

@wkurniawan07 do you think this is a good first issue?

@wkurniawan07
Copy link
Member Author

Not at all. This issue involves data migration. Even putting help wanted there is already pushing the limits.

@wkurniawan07 wkurniawan07 removed the help wanted Moderate difficulty, small localized change; suitable for novice contributors label Mar 3, 2022
@wkurniawan07 wkurniawan07 self-assigned this Mar 3, 2022
@wkurniawan07 wkurniawan07 removed their assignment Mar 18, 2022
@wkurniawan07 wkurniawan07 added this to the V8.X.0 milestone Apr 15, 2022
@wkurniawan07 wkurniawan07 added this to To do in Authentication Plus via automation Apr 21, 2022
@wkurniawan07 wkurniawan07 moved this from To do to In progress in Authentication Plus Jul 11, 2022
@xyliew25 xyliew25 mentioned this issue Jul 17, 2022
Merged
wkurniawan07 pushed a commit that referenced this issue Jul 26, 2022
@xyliew25
[#11586] Remove trimming of gmail.com for user accounts (#11903)
fb2a359
@xyliew25 xyliew25 mentioned this issue Aug 2, 2022
Merged
wkurniawan07 pushed a commit that referenced this issue Aug 2, 2022
@xyliew25
[#11586] Fix errors due to missed instances of trimming of `@gmail.co…
604d4de 
…m` (#11922)
@wkurniawan07 wkurniawan07 mentioned this issue Aug 3, 2022
Merged
wkurniawan07 added a commit that referenced this issue Aug 3, 2022
@wkurniawan07
[#11586] Remove trailing @gmail.com when checking for user ID equal…
3155a78 
…ity (#11923)
@xyliew25 xyliew25 mentioned this issue Aug 8, 2022
Merged
Authentication Plus automation moved this from In progress to Done Nov 2, 2022
zhaojj2209 added a commit that referenced this issue Nov 2, 2022
@xyliew25 @fsgmhoward
@hhdqirui @zhaojj2209
[#11586] Remove trimming of gmail.com for user accounts (#11927)
d32c08f 
Co-authored-by: Howard Liu <howard@ixnet.work>
Co-authored-by: wuqirui <53338059+hhdqirui@users.noreply.github.com>
Co-authored-by: Zhao Jingjing <54243224+zhaojj2209@users.noreply.github.com>
@wkurniawan07 wkurniawan07 removed this from the V8.X.0 milestone Dec 25, 2022
@kevin9foong kevin9foong mentioned this issue Jan 14, 2023
Closed
@wkurniawan07 wkurniawan07 mentioned this issue Jun 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xyliew25 xyliew25

Labels
a-Design High-level design or architecture c.Task Other non-user-facing works, e.g. refactoring, adding tests
Projects
No open projects
Authentication Plus
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#11586] Remove trimming of gmail.com for user accounts xyliew25/teammates
3 participants
@wkurniawan07 @daongochieu2810 @xyliew25