Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12081] User-friendliness: Fix margins on mobile #12096

Merged
merged 4 commits into from
Feb 19, 2023
Merged

[#12081] User-friendliness: Fix margins on mobile #12096

merged 4 commits into from
Feb 19, 2023

Conversation

weiquu
Copy link
Contributor

@weiquu weiquu commented Feb 18, 2023

Part of #12081
Sub-issue: Fix margins on mobile for all content

Outline of Solution

Add padding for main content to combat the negative margins of row.

Main issues were that of table overflows, so I added the table-responsive classes and removed some classes that were causing overflow of content from the div + leaving some blank spaces at the side.

@zhaojj2209 zhaojj2209 added the s.ToReview The PR is waiting for review(s) label Feb 18, 2023
zhaojj2209
zhaojj2209 reviewed Feb 18, 2023
View reviewed changes
Copy link
Contributor

@zhaojj2209 zhaojj2209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping to fix the table overflow! For the rest of the pages, we'll fix any overflow issues that crop up page by page.

Made some comments, after making the edits do remember to update the snapshot tests now that the frontend code has changed.

src/web/app/page.component.scss Outdated Show resolved Hide resolved
src/web/app/components/sessions-table/sessions-table.component.html Outdated Show resolved Hide resolved
src/web/app/pages-help/instructor-help-page/instructor-help-page.component.html Outdated Show resolved Hide resolved
zhaojj2209
zhaojj2209 approved these changes Feb 19, 2023
View reviewed changes
Copy link
Contributor

@zhaojj2209 zhaojj2209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zhaojj2209 zhaojj2209 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.ToReview The PR is waiting for review(s) labels Feb 19, 2023
@zhaojj2209 zhaojj2209 merged commit 9a3910c into TEAMMATES:user-friendliness Feb 19, 2023
zhaojj2209 pushed a commit that referenced this pull request Feb 19, 2023
@weiquu @zhaojj2209
[#12081] User-friendliness: Fix margins on mobile (#12096)
02f87dd 
* Redo all changes over the last few days

* Missed out a few changes

* Resolve comments

* Update tests
@weiquu weiquu mentioned this pull request Feb 19, 2023
Merged
zhaojj2209 pushed a commit that referenced this pull request Mar 23, 2023
@weiquu @zhaojj2209
[#12081] User-friendliness: Fix margins on mobile (#12096)
01bc040 
* Redo all changes over the last few days

* Missed out a few changes

* Resolve comments

* Update tests
zhaojj2209 pushed a commit that referenced this pull request Mar 23, 2023
@weiquu @zhaojj2209
[#12081] User-friendliness: Fix margins on mobile (#12096)
96d2c33 
* Redo all changes over the last few days

* Missed out a few changes

* Resolve comments

* Update tests
zhaojj2209 pushed a commit that referenced this pull request Mar 25, 2023
@weiquu @zhaojj2209
[#12081] User-friendliness: Fix margins on mobile (#12096)
1f90b8f 
* Redo all changes over the last few days

* Missed out a few changes

* Resolve comments

* Update tests
zhaojj2209 pushed a commit that referenced this pull request Mar 25, 2023
@weiquu @zhaojj2209
[#12081] User-friendliness: Fix margins on mobile (#12096)
6e8454e 
* Redo all changes over the last few days

* Missed out a few changes

* Resolve comments

* Update tests
@zhaojj2209 zhaojj2209 self-assigned this Apr 2, 2023
@zhaojj2209 zhaojj2209 added the c.Bug Bug/defect report label Apr 2, 2023
@zhaojj2209 zhaojj2209 added this to the V8.26.0 milestone Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaojj2209 zhaojj2209 zhaojj2209 approved these changes

Assignees

@zhaojj2209 zhaojj2209

Labels
c.Bug Bug/defect report s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V8.26.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@weiquu @zhaojj2209