Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User-friendliness Hero #12081

Closed
zhaojj2209 opened this issue Feb 13, 2023 · 1 comment
Closed

User-friendliness Hero #12081

zhaojj2209 opened this issue Feb 13, 2023 · 1 comment
Labels
c.Epic Feature/task that is worth many smaller sub-features/sub-tasks committers only Difficult; better left for committers or more senior developers

Comments

@zhaojj2209
Copy link
Contributor

The epic keeps track of issues related to improving TEAMMATES's accessibility and mobile-friendliness.

All work will be done on user-friendliness branch. Once the majority of issues have been fixed, the branch will be merged to master and the remaining issues will be opened to all.
@zhaojj2209 zhaojj2209 added committers only Difficult; better left for committers or more senior developers c.Epic Feature/task that is worth many smaller sub-features/sub-tasks labels Feb 13, 2023
@zhaojj2209 zhaojj2209 mentioned this issue Feb 13, 2023
Merged
This was referenced Feb 14, 2023
Closed
Merged
zhaojj2209 pushed a commit that referenced this issue Feb 19, 2023
@weiquu
[#12081] User-friendliness: Fix margins on mobile (#12096)
9a3910c 
* Redo all changes over the last few days

* Missed out a few changes

* Resolve comments

* Update tests
zhaojj2209 pushed a commit that referenced this issue Feb 19, 2023
@weiquu @zhaojj2209
[#12081] User-friendliness: Fix margins on mobile (#12096)
02f87dd 
* Redo all changes over the last few days

* Missed out a few changes

* Resolve comments

* Update tests
@weiquu weiquu mentioned this issue Feb 19, 2023
Merged
@jasonqiu212 jasonqiu212 mentioned this issue Feb 19, 2023
Merged
zhaojj2209 pushed a commit that referenced this issue Feb 20, 2023
@jasonqiu212
[#12081] User-friendliness: Make header dropdowns focusable (#12105)
78e51f4 
* Make dropdowns in menu bar focusable

* Fix unequal margins in dropdown list in menu bar

* Fix lint
@zhaojj2209 zhaojj2209 mentioned this issue Feb 20, 2023
Merged
zhaojj2209 added a commit that referenced this issue Feb 20, 2023
@zhaojj2209
[#12081] Tag all TEAMMATES pages with <main> (#12108)
5a4d614 
* Fix trailing spaces in github workflow files

* Refactor page.component.html

* Standardise word usage

* Update snapshots
@jasonqiu212 jasonqiu212 mentioned this issue Feb 25, 2023
Merged
zhaojj2209 pushed a commit that referenced this issue Feb 26, 2023
@jasonqiu212
[#12081] User-friendliness: Landmark questions in feedback sessions r…
adec083 
…esults page (#12129)

* Make [more] button in feedback sessions result page focusable

* Use headings for question number in feedback sessions result page

* Edit snapshot tests

* Change h3 to h2 tag and remove <b> tags

* Change additional info from link to button
@jasonqiu212 jasonqiu212 mentioned this issue Feb 27, 2023
Merged
@weiquu weiquu mentioned this issue Feb 27, 2023
Merged
zhaojj2209 pushed a commit that referenced this issue Feb 27, 2023
@weiquu
[#12081] Landmark questions in submit feedback page (#12104)
12e2b73 
* Landmark questions by making them headings

* Update tests

* Make questions collapsible

* Make question cards interactable

* Resolve comments

* Fix E2E issues

* Fix lint issues

* typo

* lint again
zhaojj2209 pushed a commit that referenced this issue Feb 27, 2023
@jasonqiu212
[#12081] User-friendliness: Fix evaluee/recipient mobile text wrap (#…
ce5d519 
…12139)

* Fix mobile text wrap for evaluee/recipient

* Align Evaluee/Recipient to left

* Fix lint
zhaojj2209 pushed a commit that referenced this issue Feb 27, 2023
@weiquu
[#12081] User-friendliness: Add label to text input for essay questio…
965a9fb 
…ns (#12140)

* Add labels for text question responses

* Another merge conflict
@weiquu weiquu mentioned this issue Feb 28, 2023
Merged
zhaojj2209 pushed a commit that referenced this issue Feb 28, 2023
@weiquu
[#12081] User-friendliness: Add labels for MSQ checkboxes (#12144)
8b76ab7 
* Add labels for MSQ checkboxes

* Shift to question edit form
This was referenced Feb 28, 2023
Merged
Merged
@weiquu weiquu mentioned this issue Mar 1, 2023
Merged
@jasonqiu212 jasonqiu212 mentioned this issue Mar 1, 2023
Merged
zhaojj2209 pushed a commit that referenced this issue Mar 1, 2023
@jasonqiu212
[#12081] User-friendliness: Add labels for distribute points by recip…
34f7877 
…ient questions (#12150)

* Add labels for distribute points by recipient questions

* Fix dropdown for questions with constraints

* Make method name for toggling question submission form dropdown more specific
@weiquu weiquu mentioned this issue Mar 2, 2023
Merged
@jasonqiu212 jasonqiu212 mentioned this issue Mar 3, 2023
Merged
zhaojj2209 added a commit that referenced this issue Mar 25, 2023
@zhaojj2209
[#12081] Fix remaining accessibility tests (#12223)
957fab9 
* Fix admin home page axe tests

* Fix admin accounts page

* Fix admin search page

* Fix admin sessions page

* Fix instructor course enroll page

* Fix instructor course edit page

* Undo disable rule

* Fix disabling rules

* Fix course join confirmation page

* Fix instructor courses page

* Fix instructor course student edit page

* Fix instructor course student details page

* Fix instructor session results page

* Fix datepicker

* Fix timepicker

* Fix instructor session edit page

* Fix individual deadline extension page

* Fix student activity logs page

* Fix student course details page

* Modify styling

* Modify student edit page IDs
zhaojj2209 pushed a commit that referenced this issue Mar 25, 2023
@weiquu @zhaojj2209
[#12081] User-friendliness: Fix instructor edit sessions page MCQ and…
17a72d1 
… MSQ (#12236)

* update mcq to look like msq

* attempt 1

* Fix MCQ question

* MSQ

* Fix margins and aria-hidden

* labels

* update tests

* Labels

* Tests

* Remove extra br and tabindex

* update tests
zhaojj2209 pushed a commit that referenced this issue Mar 25, 2023
@jasonqiu212 @zhaojj2209
[#12081] Modify question headers for instructor (#12228)
4bba773 
* Modify question headers in instructor edit sessions page

* Fix tests

* Fix e2e tests
zhaojj2209 added a commit that referenced this issue Mar 25, 2023
@zhaojj2209
[#12081] Add accessibility tests to XML test
385be51
@weiquu weiquu mentioned this issue Mar 25, 2023
Merged
zhaojj2209 pushed a commit that referenced this issue Mar 25, 2023
@weiquu
[#12081] User-friendliness: Change feedback path dropdowns to column …
4f028bc 
…format on mobile (#12250)

* Change dropdowns to col format on mobile

* Update tests
This was referenced Mar 25, 2023
Merged
Merged
zhaojj2209 pushed a commit that referenced this issue Mar 26, 2023
@weiquu
[#12081] User-friendliness: Add labels to instructor edit sessions pa…
a0560e5 
…ge questions (#12254)
zhaojj2209 added a commit that referenced this issue Mar 26, 2023
@weiquu @zhaojj2209
[#12081] User-friendliness: Fix visibility dropdown overflow (#12251)
171d5a1 
* Fix visibility dropdown overflow

* Update tests

---------

Co-authored-by: Zhao Jingjing <54243224+zhaojj2209@users.noreply.github.com>
@jasonqiu212 jasonqiu212 mentioned this issue Mar 26, 2023
Merged
@zhaojj2209 zhaojj2209 mentioned this issue Mar 27, 2023
Merged
@jasonqiu212 jasonqiu212 mentioned this issue Mar 27, 2023
Merged
zhaojj2209 pushed a commit that referenced this issue Mar 27, 2023
@jasonqiu212
[#12081] Wrap buttons vertically in mobile for instructor edit sessio…
7c1edfb 
…ns page (#12260)
@weiquu weiquu mentioned this issue Mar 27, 2023
Merged
@zhaojj2209 zhaojj2209 mentioned this issue Mar 27, 2023
Closed
zhaojj2209 pushed a commit that referenced this issue Mar 27, 2023
@weiquu
[#12081] User-friendliness: Fix distribute points options question (#…
23ebdf1 
…12266)
@zhaojj2209 zhaojj2209 mentioned this issue Mar 27, 2023
Merged
zhaojj2209 added a commit that referenced this issue Mar 27, 2023
@zhaojj2209
[#12081] Add user-friendliness documentation (#12261)
ffc67a0 
* Add accessibility tests documentation

* Add best practices documentation

* Add minimum screen size support

* Fix typos and grammar

* Reword accessibility docs
samuelfangjw pushed a commit that referenced this issue Mar 28, 2023
@jasonqiu212
[#12081] Fix rubric question overflow for instructors edit session pa…
20a8782 
…ge (#12263)
zhaojj2209 added a commit that referenced this issue Mar 28, 2023
@zhaojj2209
[#12081] Modify accessibility tests workflow to rerun failed tests on…
70b2ca9 
…ce (#12272)
This was referenced Mar 29, 2023
Merged
Merged
zhaojj2209 pushed a commit that referenced this issue Mar 30, 2023
@jasonqiu212
[#12081] Fix rank recipients question mobile spacing (#12299)
050daa7 
* Add label to rank recipients question inputs

* Fix rank recipients question mobile spacing

* Use bootstrap padding

* Change label id names
zhaojj2209 pushed a commit that referenced this issue Mar 31, 2023
@jasonqiu212
[#12081] Fix rank options question on instructor edit session page (#…
15d158d 
…12306)

* Add labels to rank options field

* Fix rank options question

* Remove redundant css

* Remove redundant row css

* Fix lint
@weiquu weiquu mentioned this issue Apr 1, 2023
Merged
zhaojj2209 pushed a commit that referenced this issue Apr 1, 2023
@weiquu
[#12081] User-friendliness: Fix all remaining sortable table headers (#…
7b31522 
…12325)

* extension confirm modal component

* per question view responses component

* sessions recycle bin table component

* sessions table component

* student list component

* notifications table component

* copy instructors from other courses modal component

* instructor courses page component

* copy questions from other sessions modal component

* instructor session individual extension page component

* update tests
@zhaojj2209
Copy link
Contributor Author

Closing as the majority of issues identified have been fixed and deployed. All remaining user-friendliness-related issues shall henceforth be tracked using separate GitHub issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c.Epic Feature/task that is worth many smaller sub-features/sub-tasks committers only Difficult; better left for committers or more senior developers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zhaojj2209