Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12048] Refactor v9 unit tests #12111

Merged
merged 4 commits into from
Feb 22, 2023
Merged

[#12048] Refactor v9 unit tests #12111

merged 4 commits into from
Feb 22, 2023

Conversation

samuelfangjw
Copy link
Member

@samuelfangjw samuelfangjw commented Feb 20, 2023 •
edited

Part of #12048

Outline of Solution

  • Move hibernate related methods to HibernateUtil. Extra level of indirection to facilitate testing, see "Don't mock what you don't own" heuristic.
  • Change parameters of remove in db layer from the entities id/natural key to the entity itself.
  • Updated tests to use new mocks.
  • Remove unnecessary methods in db layer.

@samuelfangjw samuelfangjw merged commit 04dd529 into TEAMMATES:v9-migration Feb 22, 2023
@samuelfangjw samuelfangjw deleted the hibernate-wrapper branch February 25, 2023 18:14
samuelfangjw added a commit that referenced this pull request Feb 26, 2023
@samuelfangjw
[#12048] Refactor v9 unit tests (#12111)
f077dac
samuelfangjw added a commit that referenced this pull request Apr 8, 2023
@samuelfangjw
[#12048] Refactor v9 unit tests (#12111)
dc1ea8f
@wkurniawan07 wkurniawan07 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging c.Task Other non-user-facing works, e.g. refactoring, adding tests labels Jan 21, 2024
@wkurniawan07 wkurniawan07 added this to the V9.0.0-beta.0 milestone Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaojj2209 zhaojj2209 zhaojj2209 approved these changes

@kevin9foong kevin9foong Awaiting requested review from kevin9foong

@hhdqirui hhdqirui Awaiting requested review from hhdqirui

Assignees
No one assigned
Labels
c.Task Other non-user-facing works, e.g. refactoring, adding tests s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V9.0.0-beta.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samuelfangjw @zhaojj2209 @wkurniawan07