[#12081] User-friendliness: Landmark questions in feedback sessions results page #12129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonqiu212
changed the title
zhaojj2209
reviewed
Feb 25, 2023
src/web/app/components/question-text-with-info/question-text-with-info.component.html
Outdated
Show resolved
Hide resolved
src/web/app/components/question-text-with-info/question-text-with-info.component.html
Outdated
Show resolved
Hide resolved
...ponents/question-text-with-info/__snapshots__/question-text-with-info.component.spec.ts.snap
Outdated
Show resolved
Hide resolved
zhaojj2209
approved these changes
Feb 26, 2023
zhaojj2209
added
s.ToMerge
zhaojj2209
pushed a commit
that referenced
this pull request
Mar 23, 2023
…esults page (#12129) * Make [more] button in feedback sessions result page focusable * Use headings for question number in feedback sessions result page * Edit snapshot tests * Change h3 to h2 tag and remove <b> tags * Change additional info from link to button
zhaojj2209
pushed a commit
that referenced
this pull request
Mar 23, 2023
…esults page (#12129) * Make [more] button in feedback sessions result page focusable * Use headings for question number in feedback sessions result page * Edit snapshot tests * Change h3 to h2 tag and remove <b> tags * Change additional info from link to button
zhaojj2209
pushed a commit
that referenced
this pull request
Mar 25, 2023
…esults page (#12129) * Make [more] button in feedback sessions result page focusable * Use headings for question number in feedback sessions result page * Edit snapshot tests * Change h3 to h2 tag and remove <b> tags * Change additional info from link to button
zhaojj2209
pushed a commit
that referenced
this pull request
Mar 25, 2023
…esults page (#12129) * Make [more] button in feedback sessions result page focusable * Use headings for question number in feedback sessions result page * Edit snapshot tests * Change h3 to h2 tag and remove <b> tags * Change additional info from link to button
zhaojj2209
added
c.Feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12081
Sub-issue: Feedback sessions results page: Landmark questions
Outline of Solution
spanelement intoh3element, so that screen reader can pick them up for more accessible navigation..question-numberto makeh3element look the same as before.tabindex="0"tag