Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12182][#12068] student viewing results: the spinner keeps going until the user clicks on the page #12183

Merged

Conversation

zhaojj2209
Copy link
Contributor

Fixes #12182
Fixes #12068

See #12182 (comment) for details of fix. The results for weighted rubric questions is now identical to that of non-weighted rubric questions for students (see below screenshot). Instructors are still able to see the detailed per recipient stats.

Screenshot 2023-03-10 at 00 13 32

@zhaojj2209 zhaojj2209 added the s.ToReview The PR is waiting for review(s) label Mar 9, 2023
Copy link
Member

@samuelfangjw samuelfangjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (pending e2e tests)

@samuelfangjw samuelfangjw changed the title [#12182] student viewing results: the spinner keeps going until the user clicks on the page [#12182][#12068] student viewing results: the spinner keeps going until the user clicks on the page Mar 9, 2023
@samuelfangjw samuelfangjw added this to the V8.24.0 milestone Mar 9, 2023
@samuelfangjw samuelfangjw added the c.Bug Bug/defect report label Mar 9, 2023
@samuelfangjw samuelfangjw self-assigned this Mar 9, 2023
@samuelfangjw samuelfangjw merged commit 6986e8a into TEAMMATES:master Mar 10, 2023
@samuelfangjw samuelfangjw deleted the 12182-fix-weighted-rubric-response branch March 10, 2023 05:51
@samuelfangjw samuelfangjw added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.ToReview The PR is waiting for review(s) labels Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c.Bug Bug/defect report s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
2 participants