-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
student viewing results: the spinner keeps going until the user clicks on the page #12182
Comments
Possibly related to #12068 |
@samuelfangjw Yup, most likely. It seems to affect other type of questions in the page as well. Can we get someone to fix it soon? |
After much investigation, I think I have a general idea of what is happening: When a student views the results of a feedback session, the frontend initially calls However, Clicking causes activity to resume, and after The fix here would therefore be to add an extra check and calculate statistics only if the weights array is not empty. This would allow the frontend to load the responses without any errors. However, I believe there is a much, much more serious issue here: the weights are not being hidden from the students in @damithc Can I confirm if students should not have any knowledge on whether the rubric question is weighted (so the statistics they view for weighted rubric questions should be the same as if the question was not weighted)? I will be adding the extra fix to hide rubric weights in |
@zhaojj2209 thanks for investigating this. I feel students should know that the rubric is weighted and also know the weights, when they are submitting responses as well as when they are viewing results. In fact knowing the weights can help them make more informed decisions when evaluating. So, there is no need to hide the weights. What do you guys think? Or did I misunderstand the question? |
@damithc As shown in the above screenshot, the students are able to view the per recipient statistics of other students as well, which I believe is not intended as these statistics are meant for instructors. This is because the rubric stats table component is shared between the instructor view results and student view results pages, but it does not differentiate between student and instructor; whether or not the per recipient statistics are shown is solely dependent on whether the question has weights. The faster fix right now would be to hide weights from the students so that the per recipient statistics will also be hidden from the students. Given that rubric weights are deliberately hidden from students in We can leave the showing of weights to students as a separate issue, as that will require more changes (specifically, unhiding the weights from students on the backend side, and refactoring the frontend rubric stats table to differentiate between student and instructor). |
Yes, that should not be shown to students. This is a serious data leak. Must be fixed ASAP.
Agreed. |
This is not a data leak. Students cannot see results of other students. The results table is constructed from the results given and received by the student. |
This should still be removed though, doesn't really make sense to have per recipient stats in the context of student responses. |
My bad for the misconception! So the per recipient stats tables would only be showing the responses that the user gave to other students. Nevertheless, I agree that it doesn't make sense for the per recipient tables to be there. |
Agreed, not really a data leak, but best to be removed from view. |
v8.23, production
Reported by a user, reproducible
When the student is viewing results using a link, the spinner for questions keep going indefinitely, until the user clicks on the page. After that, the questions show up.
Doesn't seem to affect everyone but students in this particular course is affected, so perhaps it depends on the question configuration. The first and second questions are weighted rubric question.
![image](https://user-images.githubusercontent.com/1673303/223911342-1fd26793-b57a-489a-8d9a-db444bb54421.png)
The rest are essay questions:
![image](https://user-images.githubusercontent.com/1673303/223911516-8a08853e-684b-4ea4-9879-9f54bd878a93.png)
Let me know if you need more info.
The text was updated successfully, but these errors were encountered: