Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12081] User-friendliness: Fix instructor edit sessions page MCQ and MSQ #12236

Merged
merged 12 commits into from Mar 23, 2023

Conversation

weiquu
Copy link
Contributor

@weiquu weiquu commented Mar 22, 2023

Part of #12081
Sub-issues: Instructor edit sessions page: MCQ (multiple) question
Instructor edit sessions page: MCQ (single) question

Outline of Solution
Fix drag arrow and option input by following "Distribute points (among options) question". Also made various other changes for screen reader, as well as some styling issues

@zhaojj2209 zhaojj2209 added the s.ToReview The PR is waiting for review(s) label Mar 23, 2023
Copy link
Contributor

@zhaojj2209 zhaojj2209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits

Copy link
Contributor

@zhaojj2209 zhaojj2209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaojj2209 zhaojj2209 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.ToReview The PR is waiting for review(s) labels Mar 23, 2023
@zhaojj2209 zhaojj2209 merged commit 82cc9d0 into TEAMMATES:user-friendliness Mar 23, 2023
7 checks passed
zhaojj2209 pushed a commit that referenced this pull request Mar 23, 2023
… MSQ (#12236)

* update mcq to look like msq

* attempt 1

* Fix MCQ question

* MSQ

* Fix margins and aria-hidden

* labels

* update tests

* Labels

* Tests

* Remove extra br and tabindex

* update tests
zhaojj2209 pushed a commit that referenced this pull request Mar 23, 2023
… MSQ (#12236)

* update mcq to look like msq

* attempt 1

* Fix MCQ question

* MSQ

* Fix margins and aria-hidden

* labels

* update tests

* Labels

* Tests

* Remove extra br and tabindex

* update tests
zhaojj2209 pushed a commit that referenced this pull request Mar 25, 2023
… MSQ (#12236)

* update mcq to look like msq

* attempt 1

* Fix MCQ question

* MSQ

* Fix margins and aria-hidden

* labels

* update tests

* Labels

* Tests

* Remove extra br and tabindex

* update tests
zhaojj2209 pushed a commit that referenced this pull request Mar 25, 2023
… MSQ (#12236)

* update mcq to look like msq

* attempt 1

* Fix MCQ question

* MSQ

* Fix margins and aria-hidden

* labels

* update tests

* Labels

* Tests

* Remove extra br and tabindex

* update tests
@zhaojj2209 zhaojj2209 added the c.Bug Bug/defect report label Apr 2, 2023
@zhaojj2209 zhaojj2209 self-assigned this Apr 2, 2023
@zhaojj2209 zhaojj2209 added this to the V8.26.0 milestone Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c.Bug Bug/defect report s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants