New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#12081] User-friendliness: Fix instructor edit sessions page MCQ and MSQ #12236
Merged
zhaojj2209
merged 12 commits into
TEAMMATES:user-friendliness
from
weiquu:user-friendliness
Mar 23, 2023
Merged
[#12081] User-friendliness: Fix instructor edit sessions page MCQ and MSQ #12236
zhaojj2209
merged 12 commits into
TEAMMATES:user-friendliness
from
weiquu:user-friendliness
Mar 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaojj2209
reviewed
Mar 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some nits
...ents/question-types/question-edit-details-form/msq-question-edit-details-form.component.html
Outdated
Show resolved
Hide resolved
.../app/components/question-types/question-edit-details-form/mcq-field/mcq-field.component.html
Outdated
Show resolved
Hide resolved
zhaojj2209
approved these changes
Mar 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zhaojj2209
added
s.ToMerge
The PR is approved by all reviewers including final reviewer; ready for merging
and removed
s.ToReview
The PR is waiting for review(s)
labels
Mar 23, 2023
zhaojj2209
pushed a commit
that referenced
this pull request
Mar 23, 2023
… MSQ (#12236) * update mcq to look like msq * attempt 1 * Fix MCQ question * MSQ * Fix margins and aria-hidden * labels * update tests * Labels * Tests * Remove extra br and tabindex * update tests
zhaojj2209
pushed a commit
that referenced
this pull request
Mar 23, 2023
… MSQ (#12236) * update mcq to look like msq * attempt 1 * Fix MCQ question * MSQ * Fix margins and aria-hidden * labels * update tests * Labels * Tests * Remove extra br and tabindex * update tests
zhaojj2209
pushed a commit
that referenced
this pull request
Mar 25, 2023
… MSQ (#12236) * update mcq to look like msq * attempt 1 * Fix MCQ question * MSQ * Fix margins and aria-hidden * labels * update tests * Labels * Tests * Remove extra br and tabindex * update tests
zhaojj2209
pushed a commit
that referenced
this pull request
Mar 25, 2023
… MSQ (#12236) * update mcq to look like msq * attempt 1 * Fix MCQ question * MSQ * Fix margins and aria-hidden * labels * update tests * Labels * Tests * Remove extra br and tabindex * update tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12081
Sub-issues: Instructor edit sessions page: MCQ (multiple) question
Instructor edit sessions page: MCQ (single) question
Outline of Solution
Fix drag arrow and option input by following "Distribute points (among options) question". Also made various other changes for screen reader, as well as some styling issues