Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12327] Consolidate duplicate modified timestamp modals #12403

Merged
merged 9 commits into from
May 5, 2023
Merged

[#12327] Consolidate duplicate modified timestamp modals #12403

merged 9 commits into from
May 5, 2023

Conversation

undermyumbrella1
Copy link
Contributor

Fixes #12327
Refactored timestamp modals as seperate component
UI remains unchanged
image

@jasonqiu212 jasonqiu212 added the s.ToReview The PR is waiting for review(s) label Apr 21, 2023
zhaojj2209
zhaojj2209 approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@zhaojj2209 zhaojj2209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for helping to refactor!

@zhaojj2209 zhaojj2209 added s.FinalReview The PR is ready for final review and removed s.ToReview The PR is waiting for review(s) labels Apr 25, 2023
jasonqiu212
jasonqiu212 requested changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@jasonqiu212 jasonqiu212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ellaella12, Thanks for the refactor!

Just 1 bug on the unique modal behavior for instructor courses page. Everything else looks great to me!

src/web/app/components/modified-timestamps-modal/modified-timestamps-modal.component.html Outdated Show resolved Hide resolved
src/web/app/components/modified-timestamps-modal/modified-timestamps-modal.component.html Outdated Show resolved Hide resolved
@jasonqiu212 jasonqiu212 added s.Ongoing The PR is being worked on by the author(s) and removed s.FinalReview The PR is ready for final review labels May 2, 2023
@jasonqiu212 jasonqiu212 changed the base branch from master to v9-migration May 5, 2023 01:51
@jasonqiu212 jasonqiu212 changed the base branch from v9-migration to master May 5, 2023 01:51
jasonqiu212
jasonqiu212 approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@jasonqiu212 jasonqiu212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your contribution

@jasonqiu212 jasonqiu212 merged commit c37c3fe into TEAMMATES:master May 5, 2023
@undermyumbrella1 undermyumbrella1 deleted the refactor/consolidate-timestamp-modal branch May 5, 2023 02:39
@samuelfangjw samuelfangjw added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging c.Task Other non-user-facing works, e.g. refactoring, adding tests and removed s.Ongoing The PR is being worked on by the author(s) labels Jul 14, 2023
@samuelfangjw samuelfangjw added this to the V8.28.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonqiu212 jasonqiu212 jasonqiu212 approved these changes

@zhaojj2209 zhaojj2209 zhaojj2209 approved these changes

Assignees

@jasonqiu212 jasonqiu212

@zhaojj2209 zhaojj2209

Labels
c.Task Other non-user-facing works, e.g. refactoring, adding tests s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V8.28.0
Development

Successfully merging this pull request may close these issues.

Consolidate duplicate modified timestamp modals
4 participants
@undermyumbrella1 @jasonqiu212 @zhaojj2209 @samuelfangjw