[#12333] Instructor students page: accessibility issue for course summary headers #12405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaojj2209
reviewed
Apr 23, 2023
There was a problem hiding this comment.
@athakaras Code currently fails linting, do remove the trailing space causing lint to fail.
...pp/pages-instructor/instructor-student-list-page/instructor-student-list-page.component.html
Outdated
Show resolved
Hide resolved
|
@athakaras Thanks for making the change! Please fix the lint issue before I proceed to review your PR. Thanks! |
|
Hello! Fixed all tests and all checks have passed:) |
zhaojj2209
added
s.FinalReview
samuelfangjw
added
s.ToMerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12333
Outline of Solution
Fixed the issue by merging the two tags into one 'div' tag.
Removed the unnecessary classes and fixed style by using Bootstrap
("fw-bold fs-5" for making the text bold and changing the font size).
Here is the updated UI