Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make InstructorCoursesPageActionTest independent. #1233

Closed
damithc opened this issue May 2, 2014 · 11 comments
Closed

Make InstructorCoursesPageActionTest independent. #1233

damithc opened this issue May 2, 2014 · 11 comments
Milestone

Comments

@damithc
Copy link
Contributor

damithc commented May 2, 2014

From dam...@gmail.com on October 12, 2013 16:16:16

This test passes on its own, but fails when run with others. There must be a state leak between test cases. Must be caused by using same course IDs such as "new-course". IDs used in each test case must be made independent. e.g.
"ICPAT.new-course" where ICPAT stands for InstructorCoursesPageActionTest.

Also fix other tests with similar problems:
InstructorFeedbacksPageActionTest
InstructorEvalsPageActionTest
InstructorCourseEnrollSaveActionTest

Original issue: http://code.google.com/p/teammatespes/issues/detail?id=1234

@damithc
Copy link
Contributor Author

damithc commented May 2, 2014

From QiaoLian...@gmail.com on October 16, 2013 01:50:22

Owner: QiaoLian...@gmail.com

@damithc
Copy link
Contributor Author

damithc commented May 2, 2014

From QiaoLian...@gmail.com on October 16, 2013 03:16:51

http://codereview.appspot.com/14430068

Status: ReadyForReview

@damithc
Copy link
Contributor Author

damithc commented May 2, 2014

From dam...@gmail.com on October 16, 2013 04:51:31

Status: ReadyToMerge

@damithc
Copy link
Contributor Author

damithc commented May 2, 2014

From dam...@gmail.com on October 18, 2013 20:33:20

Status: MergeInProgress

@damithc
Copy link
Contributor Author

damithc commented May 2, 2014

From dam...@gmail.com on October 18, 2013 21:22:50

Changeset contains two unnecessary changes.

  1. a change to the project launch file
  2. deletes the csv file.

Status: ChangesRequested

@damithc
Copy link
Contributor Author

damithc commented May 2, 2014

From QiaoLian...@gmail.com on October 22, 2013 00:59:17

https://codereview.appspot.com/15460047 I redo this one.

Status: ReadyForReview

@damithc
Copy link
Contributor Author

damithc commented May 2, 2014

From dam...@gmail.com on October 22, 2013 01:32:11

This issue was updated by revision 21c9ec46787f .

@damithc
Copy link
Contributor Author

damithc commented May 2, 2014

From dam...@gmail.com on October 22, 2013 01:32:22

Status: Delivered

@damithc
Copy link
Contributor Author

damithc commented May 2, 2014

From dam...@gmail.com on October 26, 2013 08:00:28

Status: Deployed
Labels: Milestone-V4.70

@damithc
Copy link
Contributor Author

damithc commented May 2, 2014

From dam...@gmail.com on February 26, 2014 01:56:39

This issue was updated by revision 21c9ec46787f .

@damithc damithc closed this as completed May 2, 2014
@damithc
Copy link
Contributor Author

damithc commented Jul 24, 2014

[Change Log]
status: null ~> status.closed

@thyageshm thyageshm modified the milestone: V4.70 Sep 22, 2014
athakaras added a commit to athakaras/teammates that referenced this issue Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants