Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12035] Fix EdgeDriver setup for E2E Tests #12510

Merged
merged 1 commit into from
Jul 12, 2023
Merged

[#12035] Fix EdgeDriver setup for E2E Tests #12510

merged 1 commit into from
Jul 12, 2023

Conversation

Zxun2
Copy link
Contributor

@Zxun2 Zxun2 commented Jul 12, 2023 •
edited
Loading

Part of #12035

Outline of Solution

Similar to what was proposed in #12216, but for the Edge browser instead

@github-actions
Copy link

Hi @Zxun2, thank you for your interest in contributing to TEAMMATES!
However, your PR does not appear to follow our contribution guidelines:

  • Title must start with the issue number the PR is fixing in square brackets, e.g. [#<issue-number>]

Please address the above before we proceed to review your PR.

weiquu
weiquu approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@weiquu weiquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@weiquu weiquu merged commit 4dfa419 into TEAMMATES:master Jul 12, 2023
9 checks passed
@samuelfangjw samuelfangjw added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging c.Task Other non-user-facing works, e.g. refactoring, adding tests labels Jul 14, 2023
@samuelfangjw samuelfangjw added this to the V8.28.0 milestone Jul 14, 2023
@samuelfangjw samuelfangjw changed the title Fix EdgeDriver setup for E2E Tests [#12035] Fix EdgeDriver setup for E2E Tests Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiquu weiquu weiquu approved these changes

Assignees

@weiquu weiquu

Labels
c.Task Other non-user-facing works, e.g. refactoring, adding tests s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V8.28.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Zxun2 @weiquu @samuelfangjw