[#12035] Fix ChromeDriver setup for E2E tests #12216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelfangjw
approved these changes
Mar 19, 2023
zhaojj2209
added
s.ToMerge
samuelfangjw
added
the
c.DevOps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12035
Currently, all E2E tests fail when using ChromeDriver due to an
Unable to establish websocket connectionerror. This PR fixes this error using a fix found on StackOverflow.Since the cross-browser workflow is only run on push to the master/release branches, I've tested the workflow on my own fork instead. Link to workflow
Note that this PR only fixes ChromeDriver setup so that E2E tests can be run using ChromeDriver. A portion of tests are still failing due to timeouts or otherwise (even though they pass on Firefox).