Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12313] Instructor sending submission reminders: missing space between checkbox and label #12553

Merged
merged 3 commits into from
Aug 19, 2023
Merged

[#12313] Instructor sending submission reminders: missing space between checkbox and label #12553

merged 3 commits into from
Aug 19, 2023

Conversation

sgadkar2
Copy link
Contributor

@sgadkar2 sgadkar2 commented Aug 12, 2023 •
edited
Loading

Fixes #12313

Outline of Solution

Used form-check and form-check-inline class from bootstrap for proper formatting of checkbox and label.

@github-actions
Copy link

Hi @sgadkar2, thank you for your interest in contributing to TEAMMATES!
However, your PR does not appear to follow our contribution guidelines:

  • Description must reference the issue number the PR is fixing, e.g. Fixes #<issue-number> (or Part of #<issue-number> if the PR does not address the issue fully)

Please address the above before we proceed to review your PR.

@weiquu
Copy link
Contributor

weiquu commented Aug 12, 2023

Hi @sgadkar2, do fix the failing lint tests before we proceed to review your PR. Thanks!

@sgadkar2
Copy link
Contributor Author

Hi, Can anyone please review this PR. Thanks!

cedricongjh
cedricongjh approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@cedricongjh cedricongjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your contribution to TEAMMATES

@cedricongjh cedricongjh added the s.FinalReview The PR is ready for final review label Aug 17, 2023
jasonqiu212
jasonqiu212 approved these changes Aug 19, 2023
View reviewed changes
Copy link
Contributor

@jasonqiu212 jasonqiu212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jasonqiu212 jasonqiu212 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.FinalReview The PR is ready for final review labels Aug 19, 2023
@jasonqiu212 jasonqiu212 merged commit 325d066 into TEAMMATES:master Aug 19, 2023
8 checks passed
@samuelfangjw samuelfangjw added this to the V8.29.0 milestone Aug 21, 2023
@samuelfangjw samuelfangjw added the c.Bug Bug/defect report label Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonqiu212 jasonqiu212 jasonqiu212 approved these changes

@cedricongjh cedricongjh cedricongjh approved these changes

Assignees

@jasonqiu212 jasonqiu212

@cedricongjh cedricongjh

Labels
c.Bug Bug/defect report s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V8.29.0
Development

Successfully merging this pull request may close these issues.

Instructor sending submission reminders: missing space between checkbox and label
5 participants
@sgadkar2 @weiquu @jasonqiu212 @cedricongjh @samuelfangjw