Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12345] Instructor courses page: other actions dropdown cut off #12611

Merged
merged 4 commits into from Nov 29, 2023
Merged

[#12345] Instructor courses page: other actions dropdown cut off #12611

merged 4 commits into from Nov 29, 2023

Conversation

Xiawanggg
Copy link
Contributor

Fixes #12345

Outline of Solution

  • The issue causing this is the IOS specific property of smooth touching scrolling.
  • I fixed it by changing the overflow-scrolling property of the responsive table from touch to auto.

The below screenshot is before I fixed it:

bug

The below screenshot is after I fixed it:

fixed

@cedricongjh cedricongjh added the s.ToReview The PR is waiting for review(s) label Oct 18, 2023
@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

3 similar comments
@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 11 days). 🐌 😢
Hope someone can get it to move forward again soon...

weiquu
weiquu approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@weiquu weiquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Will wait for #12644 to be resolved before merging

@weiquu weiquu merged commit e0c2032 into TEAMMATES:master Nov 29, 2023
9 checks passed
@wkurniawan07 wkurniawan07 added c.Bug Bug/defect report s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.ToReview The PR is waiting for review(s) labels Jan 21, 2024
@wkurniawan07 wkurniawan07 added this to the V8.30.0 milestone Jan 21, 2024
cedricongjh pushed a commit to cedricongjh/teammates that referenced this pull request Feb 20, 2024
@Xiawanggg @XiawangLi
@weiquu @cedricongjh
modify styles.scss and add overrides for table-responsive to fix drop…
ddec880 
…down menu cutoff on mobile (TEAMMATES#12611)

Co-authored-by: u7347103 <u7347103@anu.edu.au>
Co-authored-by: Wei Qing <48304907+weiquu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiquu weiquu weiquu approved these changes

@jasonqiu212 jasonqiu212 Awaiting requested review from jasonqiu212

Assignees
No one assigned
Labels
c.Bug Bug/defect report s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V8.30.0
Development

Successfully merging this pull request may close these issues.

Instructor courses page: other actions dropdown cut off
6 participants
@Xiawanggg @nusoss-bot @weiquu @wkurniawan07 @cedricongjh @XiawangLi