Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12588] Add unit tests for FeedbackPathPanelComponent #12613

Merged
merged 11 commits into from
Oct 29, 2023
Merged

[#12588] Add unit tests for FeedbackPathPanelComponent #12613

merged 11 commits into from
Oct 29, 2023

Conversation

JYH11
Copy link
Contributor

@JYH11 JYH11 commented Oct 19, 2023

Part of #12588

Outline of Solution
Add unit tests for FeedbackPathPanelComponent

cedricongjh
cedricongjh requested changes Oct 21, 2023
View reviewed changes
Copy link
Contributor

@cedricongjh cedricongjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of comments, and also changeGiverRecipientType function is not being tested here, do add tests for that

src/web/app/components/feedback-path-panel/feedback-path-panel.component.spec.ts Outdated Show resolved Hide resolved
src/web/app/components/feedback-path-panel/feedback-path-panel.component.spec.ts Outdated Show resolved Hide resolved
@cedricongjh cedricongjh self-assigned this Oct 21, 2023
@JYH11
Copy link
Contributor Author

JYH11 commented Oct 22, 2023

Thanks for the comment, I've fixed the issue that you've mentioned.
Additionally, I'd added changeGiverRecipientType test case, please check it!
Thanks!

@cedricongjh cedricongjh mentioned this pull request Oct 22, 2023
Open
cedricongjh
cedricongjh requested changes Oct 22, 2023
View reviewed changes
Copy link
Contributor

@cedricongjh cedricongjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost there, some more branches to test in changeGiverRecipientType, do ensure that all the branches are tested

src/web/app/components/feedback-path-panel/feedback-path-panel.component.spec.ts Outdated Show resolved Hide resolved
@cedricongjh cedricongjh added the s.ToReview The PR is waiting for review(s) label Oct 22, 2023
@JYH11
Copy link
Contributor Author

JYH11 commented Oct 23, 2023 •
edited

I think I'm pretty sure to cover all the branchs, test coverage seems bit higher then previous one!
Anyway, thanks for the comment, ready for review now!

cedricongjh
cedricongjh requested changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@cedricongjh cedricongjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost there, just a few minor changes!

src/web/app/components/feedback-path-panel/feedback-path-panel.component.spec.ts Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
src/web/app/components/feedback-path-panel/feedback-path-panel.component.spec.ts Show resolved Hide resolved
@JYH11
Copy link
Contributor Author

JYH11 commented Oct 25, 2023

Thanks for the comment! I've fixed the issues, please check it!

cedricongjh
cedricongjh approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@cedricongjh cedricongjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thank you for your contribution

@cedricongjh cedricongjh added s.FinalReview The PR is ready for final review and removed s.ToReview The PR is waiting for review(s) labels Oct 26, 2023
@github-actions github-actions bot mentioned this pull request Oct 26, 2023
Open
jasonqiu212
jasonqiu212 approved these changes Oct 29, 2023
View reviewed changes
Copy link
Contributor

@jasonqiu212 jasonqiu212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jasonqiu212 jasonqiu212 merged commit b4e3f42 into TEAMMATES:master Oct 29, 2023
9 checks passed
@JYH11 JYH11 deleted the 12588-add-test-feedbackpath branch October 29, 2023 06:15
@wkurniawan07 wkurniawan07 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging c.Task Other non-user-facing works, e.g. refactoring, adding tests and removed s.FinalReview The PR is ready for final review labels Jan 21, 2024
@wkurniawan07 wkurniawan07 added this to the V8.30.0 milestone Jan 21, 2024
cedricongjh pushed a commit to cedricongjh/teammates that referenced this pull request Feb 20, 2024
@JYH11 @cedricongjh
[TEAMMATES#12588] Add unit tests for FeedbackPathPanelComponent (TEAM…
b316f3e 
…MATES#12613)

* add tests

* fix the code

* fix lines

* delete few tests

* add the test again

* delete the test again to pass test

* add the test again

* add the test & fix whole structure

* fix minor things

* fix minor things

* fix minor things
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonqiu212 jasonqiu212 jasonqiu212 approved these changes

@cedricongjh cedricongjh cedricongjh approved these changes

Assignees

@cedricongjh cedricongjh

Labels
c.Task Other non-user-facing works, e.g. refactoring, adding tests s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V8.30.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JYH11 @jasonqiu212 @cedricongjh @wkurniawan07