Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12588] Improve test code coverage of QuestionResponsePanelComponent #12867

Conversation

leyguan
Copy link
Contributor

@leyguan leyguan commented Mar 6, 2024

Part of #12588

Outline of Solution

I added a few tests to cover the uncovered code.
I tried to cover everything. It's ready for review.
I only fix the test for one component, so I use the description "Part of #12588".

@leyguan
Copy link
Contributor Author

leyguan commented Mar 6, 2024

It seems I mistakenly add an unexpected file lint-output I used to test locally. How should I fix this?

@Andy-W-Developer
Copy link
Contributor

Make a copy of the entire folder first just in case.

Then give this command a try:
git rm --cached

Commit and push like a regular commit.

@leyguan
Copy link
Contributor Author

leyguan commented Mar 6, 2024

I have removed the unnecessary file and it's ready for review.

Copy link
Contributor

@cedricongjh cedricongjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test cases LGTM, could I trouble you to add the method that is being tested in the test string e.g. it('canUserSeeResponse: should allow instructors to see responses when intent is INSTRUCTOR_RESULT'), this is something we are doing for newly added test cases as it makes it easier for future developers to see exactly which method is being tested

@leyguan
Copy link
Contributor Author

leyguan commented Mar 8, 2024

I only added tested methods for the newly created tests. Or do I need to add for all of them?

@leyguan leyguan requested a review from cedricongjh March 9, 2024 00:09
Copy link
Contributor

@cedricongjh cedricongjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your contribution!

@cedricongjh cedricongjh added the s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging label Mar 11, 2024
@cedricongjh cedricongjh merged commit 8722e51 into TEAMMATES:master Mar 12, 2024
11 checks passed
@cedricongjh cedricongjh added this to the V9.0.0-beta.1 milestone Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants