[#13105] Admin managing account requests: use spinners to indicate actions in progress #13135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dishenggg
reviewed
Jun 29, 2024
src/web/app/components/account-requests-table/account-request-table.component.html
Outdated
Show resolved
Hide resolved
domoberzin
added
s.ToMerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13105
Outline of Solution
Added spinners to the buttons in
account-requests-tableandadmin-search-page.Reject Account Request
TEAMMATES.-.Online.Peer.Feedback_Evaluation.System.for.Student.Team.Projects.-.Google.Chrome.2024-06-23.17-49-56.mp4
Approve Account Request
TEAMMATES.-.Online.Peer.Feedback_Evaluation.System.for.Student.Team.Projects.-.Google.Chrome.2024-06-23.17-42-07.mp4
Reset Account Request
TEAMMATES.-.Online.Peer.Feedback_Evaluation.System.for.Student.Team.Projects.-.Google.Chrome.2024-06-23.17-50-25.mp4
Regenerate Student Key
TEAMMATES.-.Online.Peer.Feedback_Evaluation.System.for.Student.Team.Projects.-.Google.Chrome.2024-06-23.17-47-11.mp4
Regenerate Instructor Key
TEAMMATES.-.Online.Peer.Feedback_Evaluation.System.for.Student.Team.Projects.-.Google.Chrome.2024-06-23.17-47-47.mp4
Please let me know if there are any other buttons I've missed out or any other areas that also need to have the spinners. I decided not to do it for the anchor tag hyperlinks because I thought it looked weird when there's a spinner beside it.