Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

semi-automate the task of updating source/p5subset.xml and reviewing expected results #457

Open
peterstadler opened this issue Sep 10, 2020 · 2 comments
Assignees
Labels
target: testing Addresses the testing part of the process; typically has to do with the Test/ or Test2/ directory.

Comments

@peterstadler
Copy link
Member

During our last Council conf call on 2020-09-08 we discussed how to automate the (new) task of regularly updating source/p5subset.xml, reviewing, and incorporating the needed changes into the expected results.
Background: the Stylesheets test suit needs a p5subset.xml for testing ODD processing. While formerly this was dynamically pulled from the web, we recently added a dedicated p5subset.xml to the Stylesheets repo to have more control over this source for testing the Stylesheets. Hence we are now in the situation to decide on a policy (not the scope of this ticket ;) and to develop technical means to facilitate these updates (this ticket).

The proposed solution we want to explore is automating the creation of a pull request (triggered by changes to the Guidelines repo) which we then may review.

@peterstadler peterstadler added the target: testing Addresses the testing part of the process; typically has to do with the Test/ or Test2/ directory. label Sep 10, 2020
@hcayless
Copy link
Member

I'm a little unclear on precisely what we want to do here. We could have a push to the Guidelines trigger an action that

  1. Builds p5subset.xml
  2. Checks out the Stylesheets and compares the new p5subset to the one the Stylesheets contains.
  3. If they're different, do what? Trigger a pull request for p5subset? Build the examples for the Stylesheets (pretty sure there's a Make target for that) and do a pull request for p5subset and the new examples?

@peterstadler
Copy link
Member Author

peterstadler commented Sep 10, 2020

@hcayless that (do a pull request for p5subset and the new examples) sounds exactly what I'm looking into. I have a draft build file at my Stylesheets fork where I'm tying to document the process in a way that we could use it a) manually and b) as a job on Jenkins. a) is more or less trivial but nevertheless good to have it formalized, and for b) we need to provide some credentials. I'm thinking of employing our bot user @TEITechnicalCouncil with a constrained access token for only public repos (I think that's the least we have to grant).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
target: testing Addresses the testing part of the process; typically has to do with the Test/ or Test2/ directory.
Projects
None yet
Development

No branches or pull requests

3 participants