Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setting should contain placeName #1842

Closed
dariok opened this issue Dec 7, 2018 · 6 comments
Closed

setting should contain placeName #1842

dariok opened this issue Dec 7, 2018 · 6 comments

Comments

@dariok
Copy link

dariok commented Dec 7, 2018

Currently, setting may contain orgName and persName as well as the general name – but not placeName. All examples in the GL use name for the place.
I think it would be more consistent if placeName were allowed here.

@sydb
Copy link
Member

sydb commented Dec 7, 2018

  1. I agree. (But remember that <placeName> is not the same as <locale>, which already goes in <setting>.)
  2. The devil is in the details: we need to worry about whether the content model of <setting> should be changed to use model.nameLike instead of model.nameLike.agent, OR if <placeName> should be added to model.settingPart.

@sydb
Copy link
Member

sydb commented Sep 14, 2019

@dariok — Having looked at this a little more carefully, we (a Council sub-group) are wondering what is the use case for which <locale> is insufficient, and you would want a <placeName> inside <setting>?

@ebeshero
Copy link
Member

ebeshero commented Sep 14, 2019

Full Council notes that there's a good reason to put <placeName> in <setting>, to be used alongside <locale>, which is meant to indicate a sub-place, a part of a place. Assigning to @sydb , and this is green to implement.

@ebeshero ebeshero assigned sydb and unassigned peterstadler Sep 14, 2019
@sydb
Copy link
Member

sydb commented Sep 14, 2019

Council is planning on adding <placeName> to model.settingPart and changing the example on the tagdoc to use <placeName> for NYC, rather than <name>.

@ebeshero
Copy link
Member

ebeshero commented Jan 15, 2020

@sydb Are you good for adding this before the release? Or want someone else to take this on?

@sydb sydb closed this as completed in 04d4b37 Jan 16, 2020
@sydb
Copy link
Member

sydb commented Jan 16, 2020

Fixed (pending Mr. Jenkins’ approval) at 04d4b37. The concern, of course, is whether or not any ambiguous content models or detest change problems have been introduced. I checked briefly for the former, and I am pretty confident there are none.

Thanks for the reminder, @ebeshero !

hcayless pushed a commit that referenced this issue Jun 26, 2022
Add the placeName element to model.settingPart, and change an example.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants