Adjustments for deprecation of @calendar #2473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
During the 2023-10/13 council call we decided to:
|
…d time to att.calendarSystem. Added a calendar attribute with @validUntil to all the elements that it will be removed from.
…ing files I inadvertently nuked
Discovered that trying to delete @Calendar from att.datable (where it no longer exists) caused the attribute to be duplicated, not deleted. Not sure why, but the fast fix is to just stop deleting it. Of course that means these two schemas now have @Calendar when they shouldn’t. Probably need to add the 41 or so deletions needed to do so now.
... should not actually change any validation — 1. use default namespace instead of declaring tei: prefix and using it; 2. trim 2nd GI off @Ident iff needed.
raffazizzi
commented
Oct 16, 2023
P5/Exemplars/tei_jtei.odd
Outdated
| @@ -1993,9 +1993,9 @@ | |||
| <attDef ident="group" mode="delete"/> | |||
| </attList> | |||
| </classSpec> | |||
| <!-- We should be removing @calendar here!! --> | |||
There was a problem hiding this comment.
@sydb, this comment can go now, right?
There was a problem hiding this comment.
Uhhh … do we not need to do what it says, first? I mean these exemplars are not supposed to have a @calendar attribute.
There was a problem hiding this comment.
But it's done AFAIK! The attribute is no longer in att.datable in this PR's code.
raffazizzi
commented
Oct 16, 2023
P5/Exemplars/tei_lite.odd
Outdated
| <attDef ident="calendar" mode="delete"/> | ||
| </attList> | ||
| </classSpec> | ||
| <!-- We should be removing @calendar here!! --> |
There was a problem hiding this comment.
Ditto, this can go, @sydb ?
sydb
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be discussed at the next council meeting because we need to decide whether to do Step 0 below which would cause a delay to the deprecation period.
Optional Step 0:
@calendarviaatt.datable, because:Step 1:
date,docDate,origDate, andtimemembers ofatt.calendarSystem@calendarfromatt.datable@calendaron the 40+ elements that it needs to be removed from and provide@validUntilon those attributes. This will make sure that the deprecation notice appears on the guidelines as well as in the generated schema.Step 2:
@calendarfrom the elements.