Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only check untyped descs or gloss for out of date translations #622

Closed
wants to merge 1 commit into from

Conversation

raffazizzi
Copy link
Contributor

In support of TEIC/TEI#2473

Copy link
Member

@sydb sydb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks reasonable; passes all tests; TEI build works in my docker.

@joeytakeda
Copy link
Contributor

I think this has now been handled in #635 (PR: #636), more or less equivalently: where this PR adds an additional predicate—[not(@type)]—that checks just looks for any untyped desc, the current version of functions.xsl now specifies excluding deprecationInfo: [@xml:lang='en' and not( @type eq 'deprecationInfo' )]

So I think we can just close this without merging unless we'd prefer the more defensive not(@type)

@raffazizzi
Copy link
Contributor Author

Yeah @joeytakeda I think we attacked this same problem from different angles. I'm pretty sure this is no longer needed.

@raffazizzi raffazizzi closed this Oct 18, 2023
@sydb
Copy link
Member

sydb commented Oct 18, 2023

Ah! Here it is; you found it, @joeytakeda. If I could have found this the other day I would have just merged this PR, rather than creating #635 & #636.
I am undecided on whether not(@type) is better than what we have (not( @type eq 'deprecationInfo')), but think we should close this for now, either way. (And apparently @raffazizzi agrees, as he closed this while I was typing! :-)

@raffazizzi raffazizzi added this to the Release 7.56.0 milestone Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants