-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Priority list for matlab version to C #29
Comments
@PaulMBarker My C skills aren't that good, I can handle the scalar inputs and scalar output reasonably well if porting matlab to C. If dealing with array inputs and outputs, I'm going to get lost. If your C programer is still around, I would like to see the gsw_SA_CT_interp function ported to C and eventually make its way into the Python version. There is some desire in my group for a "community vetted" interpolation routine for temperature and salinity. Pinging @efiring for comments as well. |
gsw_SA_CT_interp is long and complicated; writing it all in C would be quite a job. I suspect it makes more sense to make sure the lower-level routines it uses are available in C, and then leave the final assembly of the full version to higher-level languages. I added the pchip interpolation to C, but the tensioned-spline interpolation is also used and I don't see that in GSW-C. I haven't looked closely enough to know what else would be needed. The optimization step to eliminate instabilities in the original profile will have to be skipped, or implemented in some simpler fashion that doesn't require a fancy optimization library. A quick google search does not turn up the JTech paper that describes the method. @PaulMBarker, what is its status? |
We have a new version of gsw_SA_CT_interp. This version is much simpler and does not require stabilisation. The paper for this new interpolation came back from review today and needs revisions. |
@PaulMBarker Excellent news, I look forward to seeing the paper. I'm about to head to leg 2 of the Pacific GEOTRACES cruise, while on it I plan to port the SP_salinometer method to C and update my working version of the GSW-Python with it, which has been a standing request from someone else in my lab... If folks want to wait around for this, I'll be back on reasonable internet the first week of December. |
From @PaulMBarker in #27
The text was updated successfully, but these errors were encountered: