Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flipped indexes in display of blocks and sub-blocks #792

Closed
clayne opened this issue Mar 12, 2020 · 1 comment
Closed

Flipped indexes in display of blocks and sub-blocks #792

clayne opened this issue Mar 12, 2020 · 1 comment

Comments

@clayne
Copy link
Contributor

clayne commented Mar 12, 2020

What is the version of xEdit you are using?
4.0.3

Describe the bug
A clear and concise description of what the bug is.

To reproduce
Steps to reproduce the behavior:
Any trivial script calling FullPath on an object.

Expected behavior
FullPath's output should match the actual indexes of what's in the data. For instance, if a CELL is in Exterior Cell Block 1, -2, Exterior Sub-Block 4, -6, FullPath should emit that. Instead it emits Exterior Cell Block -2, 1, Exterior Sub-Block -6, 4.

Screenshots
image

Additional context
This bug looks to have been there since 2012 atleast. The issue is that decoding of the block/sub-block data is using the order of low and high bytes in TwbGroupRecord.GetName but it should be using the order of high and low bytes as done in TwbGroupRecord.GetShortName.

@ElminsterAU
Copy link
Collaborator

this issue should be fixed in 4.0.3d

ElminsterAU added a commit that referenced this issue Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants