Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate all strings #549

Closed
wants to merge 1 commit into from
Closed

Translate all strings #549

wants to merge 1 commit into from

Conversation

emiluzelac
Copy link

Since they are not a hardcoded, all names should be translatable.

Example that most ThemeForest and WordPress.org authors will copy as-is and we require them anyways.

Since they are not a hardcoded, all names should be translatable. 

Example that most ThemeForest and .WordPress.org authors will copy as is and we require them anyways.
@jrfnl
Copy link
Contributor

jrfnl commented Apr 19, 2016

Hi @emiluzelac Thanks for this PR. I'm a bit hesitant to merge it at this point in time as it can easily lead to inconsistent translations of plugin names as theme and plugins would provide them themselves.
The alternative would be to use the translations provided by the required/recommended plugins themselves, however that would only work for plugins which are already installed and would require us to load the textdomains for all plugins involved on the TGMPA page (like WP core does on the plugins page).

Let me think about this a bit more and please let me know if you have more thoughts on this too.

@emiluzelac
Copy link
Author

Hey @jrfnl sounds great. Also see: https://github.com/Automattic/theme-tools/pull/16/files I kind of did this at the same time ;)

@emiluzelac emiluzelac closed this by deleting the head repository Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants