Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extracted a number of additional translations for TGMPA from GlotPress. #564

Merged
merged 13 commits into from
May 14, 2016

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Apr 21, 2016

Updated these with the most current tgmpa.pot file.
Purged old translations.
Made sure PO headers are correct.

Also:
Updated the existing translations to latest version of .pot & purged old text strings.

Pinging @elvishp2006 @hedii @vburlak @lewisporter :
All translation files have been updated against the latest .pot file in preparation for the release of TGMPA v 2.6.0. There have been a few string changes (not many).
If you have a chance, we'd very much appreciate it if you could do a quick review of your translation and update it if necessary based on the latest files as included in this PR.

Updated these with the most current tgmpa.pot file.
Purged old translations.
Made sure PO headers are correct.

Also:
Updated the existing translations to latest version of .pot & purged old text strings.
@jrfnl jrfnl added this to the 2.6.0 milestone Apr 21, 2016
@GaryJones
Copy link
Member

For some reason, the "Required" and "Recommended" strings in en_GB have been given translations of "REQUIRED" and "RECOMMENDED". Please change them to lowercase and generate a new .mo file.

Only new fields where added
@hedii
Copy link
Contributor

hedii commented Apr 21, 2016

@jrfnl i added missing fields in #565 for french translation

@jrfnl
Copy link
Contributor Author

jrfnl commented Apr 21, 2016

Updated en_GB as per @GaryJones remark + merged @hedii PR (thanks!)

@vburlak
Copy link
Contributor

vburlak commented Apr 21, 2016

Hi gents! Hi @jrfnl 😉
I've updated russian translation files in #566. Cheers!

@jrfnl jrfnl mentioned this pull request Apr 22, 2016
Created a new translation for Czech. Credits to Karolína Vyskočilová, http://kybernaut.cz .
@vyskoczilova
Copy link
Contributor

vyskoczilova commented Apr 26, 2016

Hi all and especially @jrfnl , I have created a pull request with my Czech translation (my first time contributing, so hopefully it's done correctly) :)

#570

dingo-d and others added 2 commits May 2, 2016 12:52
Croatian translation of TGM-Plugin-Activation
@jrfnl jrfnl mentioned this pull request May 2, 2016
# This file is distributed under the same license as the TGMPA package.
msgid ""
msgstr ""
"Project-Id-Version: TGM Plugin Activation\n"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per https://www.gnu.org/software/gettext/manual/html_node/Header-Entry.html, this field (for each file) should contain the project name AND version.

Copy link
Contributor Author

@jrfnl jrfnl May 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is inconsistent with how GlotPress serves translations and fills in the Project-Id-Version header. Which should be leading in this case ?

Side-note - looks like I just discovered a bug in GlotPress - was checking how it served the headers and for themes it uses just the theme name (no version nr), for plugins it says 'stable (latest release)' without the plugin name - also for the header at the very top of the files.

Off to find out where I can fix/report this.

Edit: bug reported in GlotPress/GlotPress#442

@jrfnl jrfnl force-pushed the feature/additional-translations branch from b8b4dad to fb46927 Compare May 14, 2016 12:53
@jrfnl
Copy link
Contributor Author

jrfnl commented May 14, 2016

@GaryJones Updated the last commit in this PR for your remarks.

@GaryJones GaryJones merged commit c2585ab into develop May 14, 2016
@GaryJones GaryJones deleted the feature/additional-translations branch May 14, 2016 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants