This repository has been archived by the owner on Mar 27, 2020. It is now read-only.
Working prototype #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Only respond to signed mails - Make sure all file are closed in for-loop, not only the last one
…l debugging output. Also we should always call log.Panic*() instead of log.Fatal*().
…onse successfully.
Current coverage is 63.06%@@ master #29 diff @@
==========================================
Files 9 11 +2
Lines 519 639 +120
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 380 403 +23
- Misses 77 167 +90
- Partials 62 69 +7
|
| "To": m.RecipientEmail, | ||
| "Message-ID": now.Format(time.RFC3339Nano) + "@gpg-validation.tngtech.com>", | ||
| "Message-ID": now.Format(time.RFC3339Nano) + "@gpg-validation.server.local>", |
There was a problem hiding this comment.
We should make this configurable, maybe use the From: address? Maybe we should open an issue for the whole configuration thing.
There was a problem hiding this comment.
Yes, that would be very useful: #30
|
Nice! I think we should merge this, close the old issues, and open up new ones on individual points. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the fully working prototype. All features of #9, #10 and #11 should be implemented and working.
There might be a few rough edges left, feel free to try it out yourself.
I only tried it locally so far, but I'm trying to get it to work on AWS.
There are still a lot of tests missing...