Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prediction by surrogate is not done in the iterative steps in the samplers #22

Closed
merijnpepijndebakker opened this issue Sep 27, 2022 · 1 comment
Closed

prediction by surrogate is not done in the iterative steps in the samplers #22

merijnpepijndebakker opened this issue Sep 27, 2022 · 1 comment
Assignees
@merijnpepijndebakker

Comments

@merijnpepijndebakker
Copy link
Collaborator

it seems that the surrogate is not evaluated properly during the sampling process.
in the beginning there is a prediction step, but it isn't done afterwards in the sampling anymore. This results in evaluation based on the first surrogate fit every iteration.

this should be checked and fixed
@merijnpepijndebakker merijnpepijndebakker self-assigned this Sep 27, 2022
@merijnpepijndebakker
Copy link
Collaborator Author

this has been solved in pull request #25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@merijnpepijndebakker merijnpepijndebakker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@merijnpepijndebakker