Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update unsafe React lifecycle methods #275

Open
JasonKleinert opened this issue Mar 16, 2020 · 1 comment
Open

Update unsafe React lifecycle methods #275

JasonKleinert opened this issue Mar 16, 2020 · 1 comment
Assignees

Comments

@JasonKleinert
Copy link
Contributor

JasonKleinert commented Mar 16, 2020

React is deprecating 3 of their lifecycle methods in the upcoming version 17 release. These are:

  • componentWillMount
  • componentWillreceiveProps
  • componentWillUpdate

We should determine if it's worth updating this app or not. I know we hadn't really planned on updating the React version, but may have to eventually.

For now the code will continue to work with deprecation warnings and possible bugs. We need to identify where these are used and update our code with the recommended alternatives. Guidance found here: https://reactjs.org/blog/2018/03/27/update-on-async-rendering.html

@JasonKleinert
Copy link
Contributor Author

Affected source code

componentWillMount

  • src/app/public/src/components/PlacePivotTable.jsx
  • src/app/public/src/components/ProjectPivotTable.jsx

componentWillReceiveProps

  • src/app/public/src/components/charts/Treemap.jsx
  • src/app/public/src/components/DecadeSelector.jsx
  • src/app/public/src/components/maps/PrjThemeMap.jsx
  • src/app/public/src/components/maps/ThemeMap.jsx
  • src/app/public/src/components/PlacePivotTable.jsx
  • src/app/public/src/components/PrjThemeSelector.jsx
  • src/app/public/src/components/SrcThemeSelector.jsx
  • src/app/public/src/components/ThemeSelector.jsx
  • src/app/public/src/components/views/EntityView.jsx
  • src/app/public/src/components/views/PlaceView.jsx
  • src/app/public/src/components/views/ProjectView.jsx
  • src/app/public/src/components/views/SourceView.jsx
  • src/app/public/src/components/views/StatewideView.jsx
  • src/app/public/src/components/views/UsageTypeView.jsx
  • src/app/public/src/components/views/WmsTypeView.jsx
  • src/app/public/src/components/views/WmsView.jsx

componentWillUpdate

  • src/app/public/src/components/charts/BarChart.jsx
  • src/app/public/src/components/charts/LineChart.jsx
  • src/app/public/src/components/charts/PieChart.jsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants