Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dag class update #519

Open
3 tasks
PaulFarault opened this issue Nov 22, 2023 · 0 comments
Open
3 tasks

Dag class update #519

PaulFarault opened this issue Nov 22, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@PaulFarault
Copy link
Contributor

PaulFarault commented Nov 22, 2023 •
edited by sergkudinov
Loading

The Dag class has not been reworked since a while. Some improvements can be done:

  • Class should be immutable (as we did for Collections).
  • Some helper (mostly filters) don't depend on the class, they could be extracted.
  • Methods input take operation names as string. We could replace it by operation objects.
@PaulFarault PaulFarault added the enhancement New feature or request label Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PaulFarault