Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate Diagnostic Features at Every Diagnostic Cycle #567

Closed
pasinger opened this issue Mar 17, 2022 · 2 comments
Closed

Calculate Diagnostic Features at Every Diagnostic Cycle #567

pasinger opened this issue Mar 17, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@pasinger
Copy link
Collaborator

Currently, diagnostic features are calculated at the first and second diagnostic and the difference between the two is reported. This format is amenable to early prediction, but analysis of the battery health across lifetime would be better served by having the features reported across every cycle.

Some diagnostic information is available in the structured data in the diagnostic_summary field, but what's available there is not comprehensive.

I propose making a distinction between 1) "EarlyFeatures", which are a difference on the first two diagnostics (or between the first and some other diagnostic number specified in the featurizer hyperparameters) and 2) "CycleFeatures", which are the diagnostic features reported across all diagnostic cycles.

@pasinger pasinger added the enhancement New feature or request label Mar 17, 2022
@shijingsun-TRI
Copy link
Contributor

@ardunn would you help write unit tests for issue please? Thank you!

@ardunn
Copy link
Collaborator

ardunn commented Mar 17, 2022

Sure.

Since this pertains directly to the PR, I'm just going to copy+paste @pasinger 's text there and close this issue, as everything in this issue will be in the PR

@ardunn ardunn closed this as completed Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants