Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CapFrac does not work as specified if c0 is not ~0 #60

Open
lightningclaw001 opened this issue Jun 30, 2021 · 5 comments
Open

CapFrac does not work as specified if c0 is not ~0 #60

lightningclaw001 opened this issue Jun 30, 2021 · 5 comments
Assignees
@lightningclaw001
Labels
bug Something isn't working

Comments

@lightningclaw001
Copy link
Collaborator

No description provided.

@lightningclaw001 lightningclaw001 self-assigned this Jun 30, 2021
@d-cogswell
Copy link
Collaborator

Maybe now is a good time to remove capFrac. It has been deprecated since 0.1.4.

@lightningclaw001
Copy link
Collaborator Author

i feel like capfrac is still useful (like for example, if we use NMC batteries that need to be cut off at a certain voltage or capacity), are you sure we should just remove it?

@d-cogswell
Copy link
Collaborator

The limits we need are voltage, time, and capacity. Right now we have voltage and time, and it would be good to add capacity. capfrac is really just another (confusing) way of implementing a time cutoff.

@lightningclaw001
Copy link
Collaborator Author

yes, that makes sense! i will just remove it in this issue then.

@lightningclaw001
Copy link
Collaborator Author

i think most of the test cases have capFrac in them so it changes the test case solutions, should we just rewrite all the test cases?

@d-cogswell d-cogswell added the bug Something isn't working label Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lightningclaw001 lightningclaw001

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lightningclaw001 @d-cogswell