Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading deprecated warning in cthyb 2.2.x regarding measure_G_l and measure_G_tau #124

Closed
the-hampel opened this issue Nov 14, 2019 · 1 comment
Labels

Comments

@the-hampel
Copy link
Member

In the most recent 2.2.x cthyb version I get a warning that makes not much sense. I think there was a mistake made in commit 7a7ad09 . The warning is:

WARNING: cthyb.solve parameter measure_G_l is deprecated use measure_G_l.
WARNING: cthyb.solve parameter measure_G_tau is deprecated use measure_G_tau.

This is not really meaningful, as it tells me to use the same key as I already used. Moreover, this should be the correct solver parameter according to https://triqs.github.io/cthyb/latest/reference/solve_parameters.html . I think recently the measure_G_l was renamed from measure_g_l to measure_G_l, and there was a warning implemented if not changed properly. Maybe, in the last commit this was also mistakenly changed in the warning of https://github.com/TRIQS/cthyb/blob/4fc601eaa4ec8853d2633ef680c6ce62671668d9/python/triqs_cthyb/solver.py/ . Could someone have a look?

Thanks,
Alex

@Wentzell
Copy link
Member

@the-hampel Thank you for pointing this out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants