Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Won't build on FreeBSD clang 4.0 #86

Closed
ghost opened this issue May 4, 2018 · 7 comments
Closed

Won't build on FreeBSD clang 4.0 #86

ghost opened this issue May 4, 2018 · 7 comments
Assignees
Labels

Comments

@ghost
Copy link

ghost commented May 4, 2018

[ 15%] Building CXX object c++/CMakeFiles/cthyb_c.dir/impurity_trace.cpp.o                                                                                    
In file included from /home/md/src/git/cthyb/c++/impurity_trace.cpp:21:                                                                                       
In file included from /home/md/src/git/cthyb/c++/impurity_trace.hpp:25:                                                                                       
/home/md/src/git/cthyb/c++/triqs/utility/rbt.hpp:664:7: error: expected member name or ';' after declaration specifiers                                       
 void _assert(bool c) const {                                                                                                                                 
 ~~~~ ^                                                                                                                                                       
/usr/include/assert.h:50:22: note: expanded from macro '_assert'                                                                                              
#define _assert(e)      ((void)0)                                                                                                                             
                          ^                                                                          
@krivenko
Copy link
Contributor

krivenko commented May 4, 2018

Hi Mike,

Could you please post your CMake output? Also, what branch of cthyb are you trying to use (master or unstable)?

@ghost
Copy link
Author

ghost commented May 4, 2018

Hi,

Using master.

Should I post CMakeCache.txt?

@krivenko
Copy link
Contributor

krivenko commented May 4, 2018

Nevermind, I can already see the problem.
There is a name collision between triqs::utility::rb_tree::_assert() and a macro that is apparently defined in /usr/include/assert.h on FreeBSD.

@HugoStrand Can we just get rid of that _assert() method? It does not really make sense...

@ghost
Copy link
Author

ghost commented May 4, 2018

Yes, I've actually made it compile by renaming that method there now.

@krivenko krivenko added the bug label May 4, 2018
@HugoStrand HugoStrand self-assigned this Jun 21, 2018
@HugoStrand
Copy link
Member

Dear Mike,

Thank you for reporting the problem, I have renamed the assert in commit ad51178 on the unstable branch. Please reopen this issue if that does not fix the problem.

Best regards,
Hugo

@ghost
Copy link
Author

ghost commented Jul 2, 2018

Thank you, it builds alright!

@HugoStrand
Copy link
Member

Dear Mike, Super! Thank you for the feedback. Best, Hugo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants