-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
International search #170
Comments
|
Hi @TWiStErRob . Thanks for the app, it's really great! Just curious, are you planning to fix cyrillic search soon? Or it's not in near feature plans? This is really critical that you are unable to search in Cyrillic . Thanks! |
@razumeiko I have prepared for this change for many months now, getting closer. I'm sorry to say, but I'm disabling distribution in Cyrillic script countries until this is fixed. Because I'm getting too many bad reviews for a feature that's listed explicitly as not available in the Play Store description. Existing installs will stay. Sideloading from e.g. apkpure is still possible. Most recent 1*:
|
@razumeiko can you please help me a bit? I just double-checked this and Cyrillic character search works just fine since the first version (this screenshot is from my original first published version): Can you please send me some item names, and search queries that you would expect to work differently? |
Hey, @TWiStErRob , here is what I found. Interesting, the search works but only if the word is lowercase. You can see if I have item with three words with part "тест", one upper and all other lower cases, search will find this lower cased but will not find same word with upper I tested the same experiment with English words, and they works as expected, here search is case-insensitive. Also it does not matter if you are trying to search exactly as it is with uppercase, if the word has uppercase it will not go to the search no matter how you write it in the search box. |
Thanks @razumeiko! I see why people say it's "bad". Search only works with non-latin if the whole inventory has lower-case only name, but the "Item Name" field automatically starts with an upper-case letter, so people won't do this, unless they intentionally want to. The search engine I used only supported ASCII (latin) case-insensitive search (old Android). The new one is Unicode, so it knows how to map all scripts. Oddly when searching the search query was lower-cased correctly, I probably do that manually somewhere in the code, I'll have to remove that to make it consistent. I got the fix for this (just using a better search engine); left: bad, right: fixed. |
Nice! Waiting for this update. Thanks for your hard work! |
Cyrillic characters are not searchable because they're probably tokenized wrong by FTS.
And has become the default in Android 5.0 (API 21) SQLite 3.8.6:
According to https://stackoverflow.com/a/4377116/253468
minSdkVersion=21
is required for this: Remove Android KitKat and lower compatibility (API 10-19) #178Not working:
The text was updated successfully, but these errors were encountered: