[FEATURE] Synchronise xmlns extraction with TYPO3 CMS #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to slight differences in how Fluid detects xmlns declarations in templates, TYPO3 CMS has had to deliver not one, but two separate methods of detecting and registering namespaces. This patch synchronises the behavior and removes the need for TYPO3 CMS to process the template for namespaces. There is one main difference introduced by this patch: All xmlns declarations are now stripped from the tag; and the tag itself is stripped away if `data-namespace-typo3-fluid="true"` is set on the tag.
|
Pinging @kitsunet - you may be able to remove a couple of files if you bump the Fluid version requirement to the up-coming 2.3.0 release (which I will make if/when this PR gets merged). More precisely:
And of course all usages of those. The behaviors they provide should all be supported by Fluid itself after this PR. Removing them should also improve performance slightly (it's always good to not need a pre-processing step!). |
mneuhaus
approved these changes
Feb 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to slight differences in how Fluid detects xmlns declarations
in templates, TYPO3 CMS has had to deliver not one, but two
separate methods of detecting and registering namespaces.
This patch synchronises the behavior and removes the need for
TYPO3 CMS to process the template for namespaces.
There is one main difference introduced by this patch:
All xmlns declarations are now stripped from the tag; and the tag
itself is stripped away if
data-namespace-typo3-fluid="true"is set on the tag.