[BUGFIX] Explicitly set variables should override local variables #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default behavior of the newly introduced local and global variable scopes has been that existing local variables are preferred over global variables if both exist. While this makes sense in general, if a local variable gets overwritten by a VariableViewHelper, this value couldn't be used in the local context because the local variable still had its old value. This change makes sure that both the local and the global variable get the new value. This eliminates the described inconsistencies when using a name of a local variable for a global variable.
s2b
changed the title
sbuerk
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default behavior of the newly introduced local and global variable scopes has been that existing local variables are preferred over global variables if both exist. While this makes sense in general, if a local variable gets overwritten by a VariableViewHelper, this value couldn't be used in the local context because the local variable still had its old value.
This change makes sure that both the local and the global variable get the new value. This eliminates the described inconsistencies when using a name of a local variable for a global variable.
Resolves #846