[BUGFIX] Re-enable arbitrary aria- and data- arguments #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A previous optimation broke the ability to use arbitrary ViewHelper attributes in TagBasedViewHelpers that start with aria-* and data-*. This patch re-implements this functionality. A following patch will allow all arbitrary attributes for TagBasedViewHelpers. This is a pre-patch to fix the existing regression in Fluid.
s2b
force-pushed
the
bugfix/vhDataAttributes
branch
from
57d6501
to
5cdb30a
Compare
s2b
changed the title
lolli42
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous optimation broke the ability to use arbitrary
ViewHelper attributes in TagBasedViewHelpers that start with
aria-* and data-*. This patch re-implements this functionality.
A following patch will allow all arbitrary attributes for
TagBasedViewHelpers. This is a pre-patch to fix the existing
regression in Fluid.