stuck in infinite loop when deleting a file #113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i use a S3 FAL Driver and it gets stuck in this infinite loop when trying to delete a file. i posted a issue there, andersundsehr/aus_driver_amazon_s3#36 but now i think its this error here, i noticed the error when updating from 8.7.15 to 8.7.16 and should also be here in master. line 3082: to me it doesnt make ANY sense that the identifier of the parent is the same as the folder itself thus, the do while loop never exits. i hope my PR is the fix and doesnt break anything. it looks fine for me in 8.7.16 i also think its bad practice to use do while loops because its very easy to make a mistake and get stuck in the loop and also i found this very hard to understand and so it took me quite a while to understand this code, especially the isFolderLoop condition.
|
Thank you for your contribution to TYPO3. We are using Gerrit Code Review for our contributions and took the liberty to convert your pull request to a review in our review system. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i use a S3 FAL Driver and it gets stuck in this infinite loop when trying to delete a file. i posted a issue there, andersundsehr/aus_driver_amazon_s3#36
but now i think its this error here, i noticed the error when updating from 8.7.15 to 8.7.16 and should also be here in master.
line 3082: to me it doesnt make ANY sense that the identifier of the parent is the same as the folder itself thus, the do while loop never exits. i hope my PR is the fix and doesnt break anything. it looks fine for me in 8.7.16
i also think its bad practice to use do while loops because its very easy to make a mistake and get stuck in the loop and also i found this very hard to understand and so it took me quite a while to understand this code, especially the isFolderLoop condition.