Fix Forge #78731 RTE - Regular Text Element - Fullscreen Rich Text Ed… #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Leonie, Thank you for your contribution to TYPO3. We are using Gerrit Code Review for our contributions and took the liberty to convert your pull request to a review in our review system. |
reviewtypo3org
pushed a commit
that referenced
this pull request
Sep 26, 2022
Add static library functions that allow using base64url-compliant values (according to https://tools.ietf.org/html/rfc4648#section-5). The difference to classic base64 is, that the result alphabet is adjusted like shown below, padding (`=`) is stripped completely: + position #62: `+` -> `-` (minus) + position #63: `/` -> `_` (underscore) Resolves: #92509 Releases: main, 11.5 Change-Id: I8804824f3a7fb4e08e18ef6dee6826744dbd41bc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66075 Tested-by: core-ci <typo3@b13.com> Tested-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by: Benjamin Franzke <bfr@qbus.de> Tested-by: Oliver Hader <oliver.hader@typo3.org> Reviewed-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by: Benjamin Franzke <bfr@qbus.de> Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
reviewtypo3org
pushed a commit
that referenced
this pull request
Sep 26, 2022
Add static library functions that allow using base64url-compliant values (according to https://tools.ietf.org/html/rfc4648#section-5). The difference to classic base64 is, that the result alphabet is adjusted like shown below, padding (`=`) is stripped completely: + position #62: `+` -> `-` (minus) + position #63: `/` -> `_` (underscore) Resolves: #92509 Releases: main, 11.5 Change-Id: I8804824f3a7fb4e08e18ef6dee6826744dbd41bc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75868 Tested-by: core-ci <typo3@b13.com> Tested-by: Oliver Hader <oliver.hader@typo3.org> Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…iting doesn't work
https://forge.typo3.org/issues/78731