Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xposed back #8

Closed
ravilov opened this issue Apr 25, 2021 · 8 comments
Closed

Add xposed back #8

ravilov opened this issue Apr 25, 2021 · 8 comments
Labels
enhancement Enhancement to existing feature or functionality

Comments

@ravilov
Copy link

ravilov commented Apr 25, 2021

Please consider adding Xposed part back. It was very much used and works perfectly. I've been using it like that for a very long time now. It eliminates the need for a background service and a permanent notification. Hooking directly into an app's crash handler is a much more elegant approach than constantly monitoring logcat.

@binarynoise
Copy link

Came here to say the same.

Using xposed also catches some crashes that aren't logged to logcat

@TacoTheDank TacoTheDank added the enhancement Enhancement to existing feature or functionality label Apr 26, 2021
@TacoTheDank
Copy link
Owner

Well, ok, sure. Only the GitHub-flavored releases will support it though.

JCenter is deprecated, but it's where the Xposed API libraries are maintained. JCenter will eventually shut down, so I have to add them locally so they don't suddenly disappear on me. However, F-Droid does not support building apps with precompiled binaries for security reasons. Thus, I can only support Xposed through GitHub releases.

Just remember to use the GitHub releases if you want to use Scoop with Xposed. Also, remember to check for updates every now and again, as people using my GitHub releases won't be able to update the app through F-Droid due to different key signatures. There's a source code link in the app's about section so it should be pretty easy to check if there's a new release.

Thanks!

@binarynoise
Copy link

Thank you!

@binarynoise
Copy link

binarynoise commented Apr 27, 2021

An idea to circumvent jcenter:
Can't we add the xposed-api-repo as git submodule/subrepo or something similar?

And I just found out:
rovo89 tries to host a maven repo on the github pages:
see this commit

@TacoTheDank
Copy link
Owner

@binarynoise Ah I didn't notice he had set up a thing like that.

Just our luck though, F-Droid also maintains their own list of repositories they allow, so that wouldn't be possible either :(

I did think about adding it as a submodule. However, that's one more thing that F-Droid would have to go through and verify every time, and it makes the Scoop repository more cluttered as well. I figure it wouldn't really be worth it.

@binarynoise
Copy link

jitpack.io is allowed, so it should be possible to use that to get the xposed api. Alternatively we could create an issue to encourage the xposed maintainer to move to one of the accepted platforms

@TacoTheDank
Copy link
Owner

TacoTheDank commented Apr 27, 2021

Dang, I actually completely forgot about Jitpack there.

...but the builds fail https://jitpack.io/#rovo89/XposedBridge :(

Only option now is to open an issue and see if he responds.

@TacoTheDank
Copy link
Owner

Decided to just add back Xposed using Jcenter for the time being. If this isn't resolved by the time Jcenter officially shuts down, then I'll have to remove Xposed support for F-Droid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to existing feature or functionality
Projects
None yet
Development

No branches or pull requests

3 participants