-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add conditional dependicies for older versions of Python on tox #180
Conversation
This fixes two immediate issues:
An alternate way to deal with this would be move the dependencies to the |
Alas, fixing the requirements for the tests to run is not enough. The change to |
For Python 3.3, its support was ended a few month ago, so maybe we could remove it from tox? I agree with @SpotlightKid for Python 2.7 & Arrow. This is very unfortunate though. We should consider removing Arrow for something more stable at some point (https://github.com/sdispater/pendulum for instance). |
I've submitted a PR to arrow to fix the issue. Version 0.11 (of arrow) does appear to be broken, but version 0.12 does work, if you install from source (and not from a cached wheel generated by Python 3; pip shares a cache between all version installed on a machine). So this issue with arrow will never appear if you only have Python 2.7 on your system. To test this yourself, try install arrow on your system by ignoring the cache ( So the issue is a weird combination of pip, wheel, arrow, and multiple Python versions installed on the same machine. It may actually be possible to maintain the I'm just leary of pinning a dependency to a maximum version like this because for me, watson is installed at a system level, and with the dependency pinned I can't upgrade it for anything else. I know that is discouraged on Linux systems, but I work on Windows and this works well, barring dependency hell, as there is to "system Python" to break. |
But the documentation also says:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest merging only the last four added lines to tox.ini
and removing the max version restriction for arrow again when there's a new arrow release.
eb8c175
to
735897f
Compare
What if I just blacklist the "broken" versions of arrow? |
Yes, that would work too. But until there's a fixed arrow release it makes now difference to the way |
Ok, you've convinced me, I'll merge this as it is now. Let's hope that the next |
Awesome! Here's the arrow PR to watch... |
The update to arrow has been merged and released as version 0.12.1. PR #210 has been created to provide that change. |
Requirements vary slightly between different version of Python. This allows tox to deal with that.