[MIRROR] [MDB IGNORE] Hides worn PDAs (#5433)

Original PR: tgstation/tgstation#74838 ----- ## About The Pull Request PDAs no longer have a visible appearance on your character when equipped in the belt or ID slot. ![image](https://user-images.githubusercontent.com/7483112/232916683-02e41ece-6c70-4cac-b242-24fb60b6c41a.png) ![image](https://user-images.githubusercontent.com/7483112/232916703-40d0fc65-ed25-4a7b-97be-e09c5925ba44.png) Pictured: ![image](https://user-images.githubusercontent.com/7483112/232915339-ae3b9879-9415-476f-ba89-a7e59bd6a749.png) Me uh... not visibly wearing a PDA? ## Why It's Good For The Game There's virtually no game advantage gained by knowing whether someone is or is not wearing a PDA, and even if there were they could just as easily have it in a pocket or other storage slot. They create visual noise on your sprite and are an accessory that virtually everyone always has, making the game look worse. When ID card sprites were restored as part of a bug fix when introducing missing worn icon unit testing, they were intentionally hidden again for similar reasons. ## Changelog :cl: imagedel: you can no longer tell if someone is wearing a PDA by looking at them /:cl: Co-authored-by: Jacquerel <hnevard@gmail.com>
TaleStation · Apr 20, 2023 · 781e7f0 · 781e7f0
1 parent 5096655
commit 781e7f0
Show file tree

Hide file tree

Showing 55 changed files with 1 addition and 1 deletion.
diff --git a/code/modules/modular_computers/computers/item/pda.dm b/code/modules/modular_computers/computers/item/pda.dm
@@ -2,7 +2,7 @@
 	name = "pda"
 	icon = 'icons/obj/modular_pda.dmi'
 	icon_state = "pda"
-	worn_icon_state = "pda"
+	worn_icon_state = "nothing"
 	base_icon_state = "tablet"
 	greyscale_config = /datum/greyscale_config/tablet
 	greyscale_colors = "#999875#a92323"

diff --git a/code/modules/unit_tests/screenshots/screenshot_antag_icons_blobinfection.png b/code/modules/unit_tests/screenshots/screenshot_antag_icons_blobinfection.png
diff --git a/code/modules/unit_tests/screenshots/screenshot_antag_icons_bloodbrother.png b/code/modules/unit_tests/screenshots/screenshot_antag_icons_bloodbrother.png
diff --git a/code/modules/unit_tests/screenshots/screenshot_antag_icons_headrevolutionary.png b/code/modules/unit_tests/screenshots/screenshot_antag_icons_headrevolutionary.png
diff --git a/code/modules/unit_tests/screenshots/screenshot_antag_icons_provocateur.png b/code/modules/unit_tests/screenshots/screenshot_antag_icons_provocateur.png
diff --git a/...modules/unit_tests/screenshots/screenshot_humanoids__datum_species_abductor.png b/...modules/unit_tests/screenshots/screenshot_humanoids__datum_species_abductor.png
diff --git a/.../modules/unit_tests/screenshots/screenshot_humanoids__datum_species_android.png b/.../modules/unit_tests/screenshots/screenshot_humanoids__datum_species_android.png
diff --git a/...modules/unit_tests/screenshots/screenshot_humanoids__datum_species_dullahan.png b/...modules/unit_tests/screenshots/screenshot_humanoids__datum_species_dullahan.png
diff --git a/...modules/unit_tests/screenshots/screenshot_humanoids__datum_species_ethereal.png b/...modules/unit_tests/screenshots/screenshot_humanoids__datum_species_ethereal.png
diff --git a/code/modules/unit_tests/screenshots/screenshot_humanoids__datum_species_fly.png b/code/modules/unit_tests/screenshots/screenshot_humanoids__datum_species_fly.png
diff --git a/code/modules/unit_tests/screenshots/screenshot_humanoids__datum_species_golem.png b/code/modules/unit_tests/screenshots/screenshot_humanoids__datum_species_golem.png
diff --git a/...unit_tests/screenshots/screenshot_humanoids__datum_species_golem_adamantine.png b/...unit_tests/screenshots/screenshot_humanoids__datum_species_golem_adamantine.png
diff --git a/...ules/unit_tests/screenshots/screenshot_humanoids__datum_species_golem_alloy.png b/...ules/unit_tests/screenshots/screenshot_humanoids__datum_species_golem_alloy.png
diff --git a/...s/unit_tests/screenshots/screenshot_humanoids__datum_species_golem_bananium.png b/...s/unit_tests/screenshots/screenshot_humanoids__datum_species_golem_bananium.png
diff --git a/.../unit_tests/screenshots/screenshot_humanoids__datum_species_golem_bluespace.png b/.../unit_tests/screenshots/screenshot_humanoids__datum_species_golem_bluespace.png
diff --git a/...dules/unit_tests/screenshots/screenshot_humanoids__datum_species_golem_bone.png b/...dules/unit_tests/screenshots/screenshot_humanoids__datum_species_golem_bone.png
diff --git a/...les/unit_tests/screenshots/screenshot_humanoids__datum_species_golem_bronze.png b/...les/unit_tests/screenshots/screenshot_humanoids__datum_species_golem_bronze.png
diff --git a/.../unit_tests/screenshots/screenshot_humanoids__datum_species_golem_cardboard.png b/.../unit_tests/screenshots/screenshot_humanoids__datum_species_golem_cardboard.png
diff --git a/...ules/unit_tests/screenshots/screenshot_humanoids__datum_species_golem_cloth.png b/...ules/unit_tests/screenshots/screenshot_humanoids__datum_species_golem_cloth.png
diff --git a/...es/unit_tests/screenshots/screenshot_humanoids__datum_species_golem_diamond.png b/...es/unit_tests/screenshots/screenshot_humanoids__datum_species_golem_diamond.png
diff --git a/...unit_tests/screenshots/screenshot_humanoids__datum_species_golem_durathread.png b/...unit_tests/screenshots/screenshot_humanoids__datum_species_golem_durathread.png
diff --git a/...ules/unit_tests/screenshots/screenshot_humanoids__datum_species_golem_glass.png b/...ules/unit_tests/screenshots/screenshot_humanoids__datum_species_golem_glass.png
diff --git a/...dules/unit_tests/screenshots/screenshot_humanoids__datum_species_golem_gold.png b/...dules/unit_tests/screenshots/screenshot_humanoids__datum_species_golem_gold.png
diff --git a/...es/unit_tests/screenshots/screenshot_humanoids__datum_species_golem_leather.png b/...es/unit_tests/screenshots/screenshot_humanoids__datum_species_golem_leather.png
diff --git a/.../unit_tests/screenshots/screenshot_humanoids__datum_species_golem_mhydrogen.png b/.../unit_tests/screenshots/screenshot_humanoids__datum_species_golem_mhydrogen.png
diff --git a/...les/unit_tests/screenshots/screenshot_humanoids__datum_species_golem_plasma.png b/...les/unit_tests/screenshots/screenshot_humanoids__datum_species_golem_plasma.png
diff --git a/...s/unit_tests/screenshots/screenshot_humanoids__datum_species_golem_plasteel.png b/...s/unit_tests/screenshots/screenshot_humanoids__datum_species_golem_plasteel.png
diff --git a/...es/unit_tests/screenshots/screenshot_humanoids__datum_species_golem_plastic.png b/...es/unit_tests/screenshots/screenshot_humanoids__datum_species_golem_plastic.png
diff --git a/...it_tests/screenshots/screenshot_humanoids__datum_species_golem_plastitanium.png b/...it_tests/screenshots/screenshot_humanoids__datum_species_golem_plastitanium.png
diff --git a/...ules/unit_tests/screenshots/screenshot_humanoids__datum_species_golem_runic.png b/...ules/unit_tests/screenshots/screenshot_humanoids__datum_species_golem_runic.png
diff --git a/...dules/unit_tests/screenshots/screenshot_humanoids__datum_species_golem_sand.png b/...dules/unit_tests/screenshots/screenshot_humanoids__datum_species_golem_sand.png
diff --git a/...les/unit_tests/screenshots/screenshot_humanoids__datum_species_golem_silver.png b/...les/unit_tests/screenshots/screenshot_humanoids__datum_species_golem_silver.png
diff --git a/...dules/unit_tests/screenshots/screenshot_humanoids__datum_species_golem_snow.png b/...dules/unit_tests/screenshots/screenshot_humanoids__datum_species_golem_snow.png
diff --git a/...s/unit_tests/screenshots/screenshot_humanoids__datum_species_golem_titanium.png b/...s/unit_tests/screenshots/screenshot_humanoids__datum_species_golem_titanium.png
diff --git a/...es/unit_tests/screenshots/screenshot_humanoids__datum_species_golem_uranium.png b/...es/unit_tests/screenshots/screenshot_humanoids__datum_species_golem_uranium.png
diff --git a/...dules/unit_tests/screenshots/screenshot_humanoids__datum_species_golem_wood.png b/...dules/unit_tests/screenshots/screenshot_humanoids__datum_species_golem_wood.png
diff --git a/code/modules/unit_tests/screenshots/screenshot_humanoids__datum_species_human.png b/code/modules/unit_tests/screenshots/screenshot_humanoids__datum_species_human.png
diff --git a/...es/unit_tests/screenshots/screenshot_humanoids__datum_species_human_felinid.png b/...es/unit_tests/screenshots/screenshot_humanoids__datum_species_human_felinid.png
diff --git a/...tests/screenshots/screenshot_humanoids__datum_species_human_krokodil_addict.png b/...tests/screenshots/screenshot_humanoids__datum_species_human_krokodil_addict.png
diff --git a/code/modules/unit_tests/screenshots/screenshot_humanoids__datum_species_jelly.png b/code/modules/unit_tests/screenshots/screenshot_humanoids__datum_species_jelly.png
diff --git a/...nit_tests/screenshots/screenshot_humanoids__datum_species_jelly_luminescent.png b/...nit_tests/screenshots/screenshot_humanoids__datum_species_jelly_luminescent.png
diff --git a/...ules/unit_tests/screenshots/screenshot_humanoids__datum_species_jelly_slime.png b/...ules/unit_tests/screenshots/screenshot_humanoids__datum_species_jelly_slime.png
diff --git a/.../unit_tests/screenshots/screenshot_humanoids__datum_species_jelly_stargazer.png b/.../unit_tests/screenshots/screenshot_humanoids__datum_species_jelly_stargazer.png
diff --git a/...it_tests/screenshots/screenshot_humanoids__datum_species_lizard_silverscale.png b/...it_tests/screenshots/screenshot_humanoids__datum_species_lizard_silverscale.png
diff --git a/...t_tests/screenshots/screenshot_humanoids__datum_species_monkey_monkey_freak.png b/...t_tests/screenshots/screenshot_humanoids__datum_species_monkey_monkey_freak.png
diff --git a/code/modules/unit_tests/screenshots/screenshot_humanoids__datum_species_mush.png b/code/modules/unit_tests/screenshots/screenshot_humanoids__datum_species_mush.png
diff --git a/...odules/unit_tests/screenshots/screenshot_humanoids__datum_species_plasmaman.png b/...odules/unit_tests/screenshots/screenshot_humanoids__datum_species_plasmaman.png
diff --git a/code/modules/unit_tests/screenshots/screenshot_humanoids__datum_species_pod.png b/code/modules/unit_tests/screenshots/screenshot_humanoids__datum_species_pod.png
diff --git a/code/modules/unit_tests/screenshots/screenshot_humanoids__datum_species_shadow.png b/code/modules/unit_tests/screenshots/screenshot_humanoids__datum_species_shadow.png
diff --git a/...modules/unit_tests/screenshots/screenshot_humanoids__datum_species_skeleton.png b/...modules/unit_tests/screenshots/screenshot_humanoids__datum_species_skeleton.png
diff --git a/code/modules/unit_tests/screenshots/screenshot_humanoids__datum_species_snail.png b/code/modules/unit_tests/screenshots/screenshot_humanoids__datum_species_snail.png
diff --git a/code/modules/unit_tests/screenshots/screenshot_humanoids__datum_species_zombie.png b/code/modules/unit_tests/screenshots/screenshot_humanoids__datum_species_zombie.png
diff --git a/...nit_tests/screenshots/screenshot_humanoids__datum_species_zombie_infectious.png b/...nit_tests/screenshots/screenshot_humanoids__datum_species_zombie_infectious.png
diff --git a/code/modules/unit_tests/screenshots/screenshot_saturnx_invisibility.png b/code/modules/unit_tests/screenshots/screenshot_saturnx_invisibility.png
diff --git a/icons/mob/clothing/belt.dmi b/icons/mob/clothing/belt.dmi