Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] [MDB IGNORE] Hides worn PDAs #5433

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Conversation

TaleStationBot
Copy link
Contributor

Original PR: tgstation/tgstation#74838

About The Pull Request

PDAs no longer have a visible appearance on your character when equipped in the belt or ID slot.

image
image

Pictured:
image
Me uh... not visibly wearing a PDA?

Why It's Good For The Game

There's virtually no game advantage gained by knowing whether someone is or is not wearing a PDA, and even if there were they could just as easily have it in a pocket or other storage slot.
They create visual noise on your sprite and are an accessory that virtually everyone always has, making the game look worse.
When ID card sprites were restored as part of a bug fix when introducing missing worn icon unit testing, they were intentionally hidden again for similar reasons.

Changelog

馃啈
imagedel: you can no longer tell if someone is wearing a PDA by looking at them
/:cl:

@keywordlabeler keywordlabeler bot added Removal Deleted, gone, sent to trash Sprites Coder sprites are located somewhere within this PR Upstream Mirror [DEPRECEATED] /TG/ merged a pull request, and now its a mirror. Watch as it pings commit-access. labels Apr 20, 2023
@Jolly-66 Jolly-66 merged commit 781e7f0 into master Apr 20, 2023
19 of 21 checks passed
@Jolly-66 Jolly-66 deleted the upstream-merge-74838 branch April 20, 2023 17:50
TaleStationBot added a commit that referenced this pull request Apr 20, 2023
github-actions bot added a commit that referenced this pull request Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Removal Deleted, gone, sent to trash Sprites Coder sprites are located somewhere within this PR Upstream Mirror [DEPRECEATED] /TG/ merged a pull request, and now its a mirror. Watch as it pings commit-access.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants